Skip to content

Commit d7dca48

Browse files
committed
Tell users to solve lowest-complexity failures first
When failure output is truncated by --max-failures, print an explicit note that failures are ordered by complexity and the displayed failures should be solved first. Keep the runner diagnostics test covering the truncation area.
1 parent 43c9e4d commit d7dca48

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

lib/liquid/spec/cli/runner.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1480,6 +1480,7 @@ def print_failures(failures, max_failures = nil)
14801480
# Show truncation message if we limited output
14811481
if max_failures && sorted_failures.size > max_failures
14821482
puts "\e[2m(... #{sorted_failures.size - max_failures} more failures not shown due to --max-failures #{max_failures} ...)\e[0m"
1483+
puts "\e[2mFailures are ordered by complexity. Solve above failures first.\e[0m"
14831484
puts ""
14841485
end
14851486
end

test/runner_diagnostics_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ def test_printed_failures_are_lowest_complexity_across_prioritized_and_suite_spe
113113
assert_includes stdout, "1) object_string_literal"
114114
refute_includes stdout, "1) high_added_failure"
115115
assert_includes stdout, "(... 1 more failures not shown due to --max-failures 1 ...)"
116+
assert_includes stdout, "Failures are ordered by complexity. Solve above failures first."
116117
end
117118
end
118119
end

0 commit comments

Comments
 (0)