Skip to content

Commit daefb42

Browse files
committed
Declare Liquid and base64 runtime dependencies
1 parent 61117cf commit daefb42

3 files changed

Lines changed: 17 additions & 3 deletions

File tree

Gemfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,4 @@ group :development do
2323
gem "activesupport", require: false
2424
end
2525

26-
gem "base64", "~> 0.3.0"
27-
2826
gem "bigdecimal", "~> 4.0"

liquid-spec.gemspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ Gem::Specification.new do |spec|
2626
spec.bindir = "bin"
2727
spec.executables = ["liquid-spec"]
2828

29-
# No runtime dependencies on liquid - the adapter provides it
29+
spec.add_dependency("base64", "~> 0.3.0")
30+
spec.add_dependency("liquid", "~> 5.13")
3031
spec.add_dependency("super_diff", "~> 0.18")
3132

3233
spec.require_paths = ["lib"]

test/gemspec_test.rb

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# frozen_string_literal: true
2+
3+
require_relative "test_helper"
4+
5+
class GemspecTest < Minitest::Test
6+
GEMSPEC_PATH = File.expand_path("../liquid-spec.gemspec", __dir__)
7+
8+
def test_required_runtime_dependencies_are_declared
9+
gemspec = Gem::Specification.load(GEMSPEC_PATH)
10+
dependencies = gemspec.runtime_dependencies.to_h { |dependency| [dependency.name, dependency.requirement] }
11+
12+
assert_equal Gem::Requirement.new("~> 0.3.0"), dependencies.fetch("base64")
13+
assert_equal Gem::Requirement.new("~> 5.13"), dependencies.fetch("liquid")
14+
end
15+
end

0 commit comments

Comments
 (0)