Skip to content

Commit 4f448c6

Browse files
committed
fix(🍏): include cpp/api, cpp/skia, cpp/jsi, cpp/rnskia, cpp/utils in HEADER_SEARCH_PATHS
Under `use_frameworks! :linkage => :static` (or Expo's `useFrameworks: 'static'`), the recursive `"$(PODS_TARGET_SRCROOT)/cpp/"/**` glob does not propagate to sibling directories, so compilation of `cpp/api/third_party/base64.cpp` fails with `'third_party/base64.h' file not found` (and similar misses for headers under `cpp/skia`, `cpp/jsi`, `cpp/rnskia`, `cpp/utils`). Add those five paths explicitly alongside the existing rnwgpu/dawn entries so static-frameworks builds resolve them. Fixes #3839.
1 parent ae228ac commit 4f448c6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎packages/skia/react-native-skia.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Pod::Spec.new do |s|
6565
'GCC_PREPROCESSOR_DEFINITIONS' => preprocessor_defs,
6666
'CLANG_CXX_LANGUAGE_STANDARD' => 'c++17',
6767
'DEFINES_MODULE' => 'YES',
68-
"HEADER_SEARCH_PATHS" => '"$(PODS_TARGET_SRCROOT)/cpp/"/** "$(PODS_TARGET_SRCROOT)/cpp" "$(PODS_TARGET_SRCROOT)/cpp/jsi2" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu/api" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu/api/descriptors" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu/async" "$(PODS_TARGET_SRCROOT)/cpp/dawn/include"'
68+
"HEADER_SEARCH_PATHS" => '"$(PODS_TARGET_SRCROOT)/cpp/"/** "$(PODS_TARGET_SRCROOT)/cpp" "$(PODS_TARGET_SRCROOT)/cpp/api" "$(PODS_TARGET_SRCROOT)/cpp/skia" "$(PODS_TARGET_SRCROOT)/cpp/jsi" "$(PODS_TARGET_SRCROOT)/cpp/jsi2" "$(PODS_TARGET_SRCROOT)/cpp/rnskia" "$(PODS_TARGET_SRCROOT)/cpp/utils" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu/api" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu/api/descriptors" "$(PODS_TARGET_SRCROOT)/cpp/rnwgpu/async" "$(PODS_TARGET_SRCROOT)/cpp/dawn/include"'
6969
}
7070

7171
s.frameworks = ['MetalKit', 'AVFoundation', 'AVKit', 'CoreMedia']

0 commit comments

Comments
 (0)