react-native-skia still breaking exceptions

[g4rb4g3]

Description

Hello again, sorry to open up another issue here 😬

Since I can not re-open #3594 I'm doing another issue related to it.
I just checked the crash logs using react-native-skia 2.4.14 and still get these unknown runtime errrors on sentry.

This is what I use for testing on swift:

A similar thing happens on Android actually when throwing an error on kotlin.
Update: this is not caused by react-native-skia

React Native Skia Version

2.4.14

React Native Version

0.79.6

Using New Architecture

• Enabled

Steps to Reproduce

Throw an error on native side and check the logs.

Snack, Code Example, Screenshot, or Link to Repository

Check #3594 for screenshots and details.

[g4rb4g3]

Could it be related to this?
I adjusted the extra_cflags_cc to get the proper exceptions while #3595 does adjust extra_cflags https://github.com/Shopify/react-native-skia/pull/3595/files#diff-1fe84d8af69f564e640beb75214048eee5afb659e7c7ba0e9a49a4c48e6d3dd1R288

This is what I specified on my skia build for iOS:

extra_cflags_cc = [
  "-fexceptions",
  "-frtti",
  "-stdlib=libc++",
]

[g4rb4g3]

yep adding ["extra_cflags_cc", `["-fexceptions","-frtti"]`], fixed it on iOS

doing similar on Android did not help anything though 😢 how can I specify similar flags for Android?

[g4rb4g3]

Ok, ignore the invalid Android exception, it is not caused by react-native-skia. Sorry for my wrong assumption.
I just removed react-native-skia from the project I see these invalid exceptions and I still get these "Unknown N8facebook3jni12JniExceptionE error." logs....

[g4rb4g3]

For the records, the broken Android exceptions are caused by react-native itself and are fixed since 0.80.0 according to this: mrousavy/nitro#382
Sadly I'm on Expo SDK 53 providing react-native 0.79.6.... time for some upgrades I guess.

[wcandillon]

@g4rb4g3 my apologies for the late reply. May I ask what the status is? In the issue I see "Update: this is not caused by react-native-skia". Is there still a bug on our side?

[g4rb4g3]

No problem, its that time of a year people are hard to reach. 🙂
Yes on iOS this is still an issue.
The Android one is not caused by skia.

[wcandillon]

I opened #3638 however I am not able yet to reproduce the issue at the moment. throwing exception on the native side on iOS works as excepted. Can you help me with the reproduction scenario?

[g4rb4g3]

A tricky one, I'm facing this on an app running on old arch with react-native 0.79.6 (Expo SDK 53) and react-native-auto-play. What I did to fix it was a custom build of react-native-skia and specified ["extra_cflags_cc", ["-fexceptions","-frtti"]] on each args array in here:
https://github.com/Shopify/react-native-skia/blob/main/packages/skia/scripts/skia-configuration.ts#L287

[wcandillon]

But we are already shipping the prebuilt binaries with these flags. What might be the current issue? Is #3638 relevant to you or not at all? I think these flags might even be default already.

[g4rb4g3]

But you specify extra_cflags while I did extra_cflags_cc, maybe that does the trick?

[wcandillon]

I ran the following commands that suggest that exception handling is enabled on the prebuilt binaries:

otool -l libs/apple/libskia.xcframework/ios-arm64_arm64e/libskia.a | grep -E "sectname (__eh_frame|__unwind_info)"
  sectname __eh_frame

does this look ok to you? I was testing the code by throwing exception on the module but I need Skia to throw an exception for testing right?

[g4rb4g3]

tbh I have no idea 😬
but I got a reproduction, clone this https://github.com/Iternio-Planning-AB/react-native-auto-play/ and check out the bug/skia-exceptions branch and run the example app, once it is up and running on the simulator add a CarPlay display.

With 2.4.14 I get the unknown std::runtime error

That one should actually show the "skia test exception" instead.

[g4rb4g3]

Adding my custom built libskia.xcframework shows the proper errror:

You can check my changes here: https://github.com/Shopify/react-native-skia/compare/main...g4rb4g3:react-native-skia:bugfix/skia-breaking-exceptions?expand=1