Skip to content

Commit 09d4555

Browse files
committed
ZJIT: DRY up underscore rexport anti-pattern
Keeping the same name makes re-exporting more concise.
1 parent 350df4f commit 09d4555

3 files changed

Lines changed: 19 additions & 22 deletions

File tree

zjit/src/backend/arm64/mod.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ use crate::cast::*;
1111
pub type Reg = A64Reg;
1212

1313
// Callee-saved registers
14-
pub const _CFP: Opnd = Opnd::Reg(X19_REG);
15-
pub const _EC: Opnd = Opnd::Reg(X20_REG);
16-
pub const _SP: Opnd = Opnd::Reg(X21_REG);
14+
pub const CFP: Opnd = Opnd::Reg(X19_REG);
15+
pub const EC: Opnd = Opnd::Reg(X20_REG);
16+
pub const SP: Opnd = Opnd::Reg(X21_REG);
1717

1818
// C argument registers on this platform
19-
pub const _C_ARG_OPNDS: [Opnd; 6] = [
19+
pub const C_ARG_OPNDS: [Opnd; 6] = [
2020
Opnd::Reg(X0_REG),
2121
Opnd::Reg(X1_REG),
2222
Opnd::Reg(X2_REG),
@@ -27,8 +27,8 @@ pub const _C_ARG_OPNDS: [Opnd; 6] = [
2727

2828
// C return value register on this platform
2929
pub const C_RET_REG: Reg = X0_REG;
30-
pub const _C_RET_OPND: Opnd = Opnd::Reg(X0_REG);
31-
pub const _NATIVE_STACK_PTR: Opnd = Opnd::Reg(XZR_REG);
30+
pub const C_RET_OPND: Opnd = Opnd::Reg(X0_REG);
31+
pub const NATIVE_STACK_PTR: Opnd = Opnd::Reg(XZR_REG);
3232

3333
// These constants define the way we work with Arm64's stack pointer. The stack
3434
// pointer always needs to be aligned to a 16-byte boundary.

zjit/src/backend/lir.rs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,16 @@ use std::mem::take;
44
use crate::codegen::local_size_and_idx_to_ep_offset;
55
use crate::cruby::{Qundef, RUBY_OFFSET_CFP_PC, RUBY_OFFSET_CFP_SP, SIZEOF_VALUE_I32};
66
use crate::options::{debug, get_option};
7-
use crate::{cruby::VALUE};
8-
use crate::backend::current::*;
7+
use crate::cruby::VALUE;
98
use crate::virtualmem::CodePtr;
109
use crate::asm::{CodeBlock, Label};
1110

12-
pub const EC: Opnd = _EC;
13-
pub const CFP: Opnd = _CFP;
14-
pub const SP: Opnd = _SP;
15-
16-
pub const C_ARG_OPNDS: [Opnd; 6] = _C_ARG_OPNDS;
17-
pub const C_RET_OPND: Opnd = _C_RET_OPND;
18-
pub const NATIVE_STACK_PTR: Opnd = _NATIVE_STACK_PTR;
19-
pub use crate::backend::current::{Reg, C_RET_REG};
11+
pub use crate::backend::current::{
12+
Reg,
13+
EC, CFP, SP,
14+
NATIVE_STACK_PTR,
15+
C_ARG_OPNDS, C_RET_REG, C_RET_OPND,
16+
};
2017

2118
// Memory operand base
2219
#[derive(Clone, Copy, PartialEq, Eq, Debug)]

zjit/src/backend/x86_64/mod.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ use crate::cast::*;
1111
pub type Reg = X86Reg;
1212

1313
// Callee-saved registers
14-
pub const _CFP: Opnd = Opnd::Reg(R13_REG);
15-
pub const _EC: Opnd = Opnd::Reg(R12_REG);
16-
pub const _SP: Opnd = Opnd::Reg(RBX_REG);
14+
pub const CFP: Opnd = Opnd::Reg(R13_REG);
15+
pub const EC: Opnd = Opnd::Reg(R12_REG);
16+
pub const SP: Opnd = Opnd::Reg(RBX_REG);
1717

1818
// C argument registers on this platform
19-
pub const _C_ARG_OPNDS: [Opnd; 6] = [
19+
pub const C_ARG_OPNDS: [Opnd; 6] = [
2020
Opnd::Reg(RDI_REG),
2121
Opnd::Reg(RSI_REG),
2222
Opnd::Reg(RDX_REG),
@@ -27,8 +27,8 @@ pub const _C_ARG_OPNDS: [Opnd; 6] = [
2727

2828
// C return value register on this platform
2929
pub const C_RET_REG: Reg = RAX_REG;
30-
pub const _C_RET_OPND: Opnd = Opnd::Reg(RAX_REG);
31-
pub const _NATIVE_STACK_PTR: Opnd = Opnd::Reg(RSP_REG);
30+
pub const C_RET_OPND: Opnd = Opnd::Reg(RAX_REG);
31+
pub const NATIVE_STACK_PTR: Opnd = Opnd::Reg(RSP_REG);
3232

3333
impl CodeBlock {
3434
// The number of bytes that are generated by jmp_ptr

0 commit comments

Comments
 (0)