Get rid of rb_gc_update_id_to_obj_table

It was a blind attempt at fixing a bug, but I'm pretty sure
it's not necessary.

In addition, `rb_evict_fields_to_hash` already copy the `object_id`
in the `st_table` via `rb_obj_copy_fields_to_hash_table`.

And `rb_evict_ivars_to_hash` shouldn't evict the `object_id`.

Author: byroot

gc.c

@@ -1810,16 +1810,6 @@ static const rb_data_type_t id_to_obj_tbl_type = {
     .flags = RUBY_TYPED_WB_PROTECTED | RUBY_TYPED_FREE_IMMEDIATELY
 };
 
-bool
-rb_gc_update_id_to_obj_table(VALUE obj, VALUE id)
-{
-    if (id_to_obj_tbl && !st_lookup(id_to_obj_tbl, id, 0)) {
-        st_insert(id_to_obj_tbl, id, obj);
-        return true;
-    }
-    return false;
-}
-
 static VALUE
 object_id(VALUE obj)
 {

internal/gc.h

@@ -262,8 +262,6 @@ void ruby_sized_xfree(void *x, size_t size);
 const char *rb_gc_active_gc_name(void);
 int rb_gc_modular_gc_loaded_p(void);
 
-bool rb_gc_update_id_to_obj_table(VALUE obj, VALUE id);
-
 RUBY_SYMBOL_EXPORT_END
 
 int rb_ec_stack_check(struct rb_execution_context_struct *ec);

variable.c

@@ -1590,16 +1590,6 @@ rb_evict_fields_to_hash(VALUE obj)
 
     // Evacuate all previous values from shape into id_table
     rb_obj_copy_fields_to_hash_table(obj, table);
-    rb_shape_t *shape = rb_shape_get_shape(obj);
-    if (rb_shape_has_object_id(shape)) {
-        rb_shape_t *object_id_shape = rb_shape_object_id_shape(obj);
-        VALUE id = rb_field_get(obj, object_id_shape);
-        st_insert(table, internal_object_id, id);
-
-        // We need to ensure the object ID is registered in id_to_obj_table
-        // before transitioning to too complex
-        rb_gc_update_id_to_obj_table(obj, id);
-    }
     obj_transition_too_complex(obj, table);
 
     RUBY_ASSERT(rb_shape_obj_too_complex(obj));
@@ -1614,16 +1604,6 @@ rb_evict_ivars_to_hash(VALUE obj)
 
     // Evacuate all previous values from shape into id_table
     rb_obj_copy_ivs_to_hash_table(obj, table);
-    rb_shape_t *shape = rb_shape_get_shape(obj);
-    if (rb_shape_has_object_id(shape)) {
-        rb_shape_t *object_id_shape = rb_shape_object_id_shape(obj);
-        VALUE id = rb_field_get(obj, object_id_shape);
-        st_insert(table, internal_object_id, id);
-
-        // We need to ensure the object ID is registered in id_to_obj_table
-        // before transitioning to too complex
-        rb_gc_update_id_to_obj_table(obj, id);
-    }
     obj_transition_too_complex(obj, table);
 
     RUBY_ASSERT(rb_shape_obj_too_complex(obj));
@@ -1895,7 +1875,7 @@ rb_ensure_iv_list_size(VALUE obj, uint32_t current_capacity, uint32_t new_capaci
 }
 
 static int
-rb_obj_copy_ivs_to_hash_table_i(ID key, VALUE val, st_data_t arg)
+rb_obj_copy_fields_to_hash_table_i(ID key, VALUE val, st_data_t arg)
 {
     RUBY_ASSERT(!st_lookup((st_table *)arg, (st_data_t)key, NULL));
 
@@ -1906,13 +1886,13 @@ rb_obj_copy_ivs_to_hash_table_i(ID key, VALUE val, st_data_t arg)
 void
 rb_obj_copy_ivs_to_hash_table(VALUE obj, st_table *table)
 {
-    rb_ivar_foreach(obj, rb_obj_copy_ivs_to_hash_table_i, (st_data_t)table);
+    rb_ivar_foreach(obj, rb_obj_copy_fields_to_hash_table_i, (st_data_t)table);
 }
 
 void
 rb_obj_copy_fields_to_hash_table(VALUE obj, st_table *table)
 {
-    rb_field_foreach(obj, rb_obj_copy_ivs_to_hash_table_i, (st_data_t)table, false);
+    rb_field_foreach(obj, rb_obj_copy_fields_to_hash_table_i, (st_data_t)table, false);
 }
 
 static VALUE *