Ractor: don't invoke initialize_* callbacks when moving an object

[Bug #20255]

Alternatively we could invoke it, but would need to do it in the
context of the newly spawned Ractor so that accessing global non-shareable
objects is not possible.

Author: byroot

internal/object.h

@@ -17,7 +17,8 @@ VALUE rb_class_search_ancestor(VALUE klass, VALUE super);
 NORETURN(void rb_undefined_alloc(VALUE klass));
 double rb_num_to_dbl(VALUE val);
 VALUE rb_obj_dig(int argc, VALUE *argv, VALUE self, VALUE notfound);
-VALUE rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze);
+VALUE rb_obj_raw_clone(VALUE obj);
+VALUE rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze, int init_callbacks);
 VALUE rb_obj_dup_setup(VALUE obj, VALUE dup);
 VALUE rb_immutable_obj_clone(int, VALUE *, VALUE);
 VALUE rb_check_convert_type_with_id(VALUE,int,const char*,ID);

object.c

@@ -404,7 +404,7 @@ init_copy(VALUE dest, VALUE obj)
 }
 
 static VALUE immutable_obj_clone(VALUE obj, VALUE kwfreeze);
-static VALUE mutable_obj_clone(VALUE obj, VALUE kwfreeze);
+static VALUE mutable_obj_clone(VALUE obj, VALUE kwfreeze, int init_callbacks);
 PUREFUNC(static inline int special_object_p(VALUE obj)); /*!< \private */
 static inline int
 special_object_p(VALUE obj)
@@ -443,7 +443,7 @@ rb_obj_clone2(rb_execution_context_t *ec, VALUE obj, VALUE freeze)
 {
     VALUE kwfreeze = obj_freeze_opt(freeze);
     if (!special_object_p(obj))
-        return mutable_obj_clone(obj, kwfreeze);
+        return mutable_obj_clone(obj, kwfreeze, true);
     return immutable_obj_clone(obj, kwfreeze);
 }
 
@@ -484,7 +484,7 @@ immutable_obj_clone(VALUE obj, VALUE kwfreeze)
 }
 
 VALUE
-rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze)
+rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze, int init_callbacks)
 {
     VALUE argv[2];
 
@@ -498,7 +498,9 @@ rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze)
 
     switch (kwfreeze) {
       case Qnil:
-        rb_funcall(clone, id_init_clone, 1, obj);
+        if (init_callbacks) {
+            rb_funcall(clone, id_init_clone, 1, obj);
+        }
         RBASIC(clone)->flags |= RBASIC(obj)->flags & FL_FREEZE;
 
         if (RB_TYPE_P(obj, T_STRING)) {
@@ -526,7 +528,9 @@ rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze)
 
         argv[0] = obj;
         argv[1] = freeze_true_hash;
-        rb_funcallv_kw(clone, id_init_clone, 2, argv, RB_PASS_KEYWORDS);
+        if (init_callbacks) {
+            rb_funcallv_kw(clone, id_init_clone, 2, argv, RB_PASS_KEYWORDS);
+        }
         RBASIC(clone)->flags |= FL_FREEZE;
         rb_shape_t * next_shape = rb_shape_transition_shape_frozen(clone);
         // If we're out of shapes, but we want to freeze, then we need to
@@ -550,7 +554,9 @@ rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze)
 
         argv[0] = obj;
         argv[1] = freeze_false_hash;
-        rb_funcallv_kw(clone, id_init_clone, 2, argv, RB_PASS_KEYWORDS);
+        if (init_callbacks) {
+            rb_funcallv_kw(clone, id_init_clone, 2, argv, RB_PASS_KEYWORDS);
+        }
         break;
       }
       default:
@@ -561,17 +567,24 @@ rb_obj_clone_setup(VALUE obj, VALUE clone, VALUE kwfreeze)
 }
 
 static VALUE
-mutable_obj_clone(VALUE obj, VALUE kwfreeze)
+mutable_obj_clone(VALUE obj, VALUE kwfreeze, int init_callbacks)
 {
     VALUE clone = rb_obj_alloc(rb_obj_class(obj));
-    return rb_obj_clone_setup(obj, clone, kwfreeze);
+    return rb_obj_clone_setup(obj, clone, kwfreeze, init_callbacks);
 }
 
 VALUE
 rb_obj_clone(VALUE obj)
 {
     if (special_object_p(obj)) return obj;
-    return mutable_obj_clone(obj, Qnil);
+    return mutable_obj_clone(obj, Qnil, true);
+}
+
+VALUE
+rb_obj_raw_clone(VALUE obj)
+{
+    if (special_object_p(obj)) return obj;
+    return mutable_obj_clone(obj, Qnil, false);
 }
 
 VALUE

proc.c

@@ -126,7 +126,7 @@ static VALUE
 proc_clone(VALUE self)
 {
     VALUE procval = rb_proc_dup(self);
-    return rb_obj_clone_setup(self, procval, Qnil);
+    return rb_obj_clone_setup(self, procval, Qnil, true);
 }
 
 /* :nodoc: */
@@ -317,7 +317,7 @@ static VALUE
 binding_clone(VALUE self)
 {
     VALUE bindval = binding_dup(self);
-    return rb_obj_clone_setup(self, bindval, Qnil);
+    return rb_obj_clone_setup(self, bindval, Qnil, true);
 }
 
 VALUE
@@ -2452,7 +2452,7 @@ method_clone(VALUE self)
 
     TypedData_Get_Struct(self, struct METHOD, &method_data_type, orig);
     clone = TypedData_Make_Struct(CLASS_OF(self), struct METHOD, &method_data_type, data);
-    rb_obj_clone_setup(self, clone, Qnil);
+    rb_obj_clone_setup(self, clone, Qnil, true);
     RB_OBJ_WRITE(clone, &data->recv, orig->recv);
     RB_OBJ_WRITE(clone, &data->klass, orig->klass);
     RB_OBJ_WRITE(clone, &data->iclass, orig->iclass);

ractor.c

@@ -3555,7 +3555,7 @@ move_enter(VALUE obj, struct obj_traverse_replace_data *data)
         return traverse_skip;
     }
     else {
-        data->replacement = rb_obj_clone(obj);
+        data->replacement = rb_obj_raw_clone(obj);
         return traverse_cont;
     }
 }

test/ruby/test_ractor.rb

@@ -71,6 +71,30 @@ def test_default_thread_group
     end;
   end
 
+  def test_initialize_clone_on_send
+    assert_separately([], "#{<<~"begin;"}\n#{<<~'end;'}")
+    begin;
+      Warning[:experimental] = false
+
+      class A
+        def initialize_clone(other)
+          raise NotImplementedError
+        end
+      end
+
+      class B
+        def initialize_copy(other)
+          raise NotImplementedError
+        end
+      end
+
+      ractor = Ractor.new { 2.times { Ractor.receive} }
+      ractor.send(A.new, move: true)
+      ractor.send(B.new, move: true)
+      ractor.take
+    end;
+  end
+
   def assert_make_shareable(obj)
     refute Ractor.shareable?(obj), "object was already shareable"
     Ractor.make_shareable(obj)