Fix an effects bug that missed some control flow instructions

Author: jacob-shops

zjit/src/hir.rs

@@ -4956,8 +4956,10 @@ impl Function {
                     },
                     insn => {
                         let insn_reads_memory = insn.effects_of().includes(Effect::read(abstract_heaps::Memory));
-                        let insn_uses_control_flow = insn.effects_of().includes(effects::Control);
-                        // TODO(Jacob): Once we update from extended basic blocks to normal basic blocks, we can remove the control flow check
+                        let insn_uses_control_flow = insn.effects_of().includes(Effect::write(abstract_heaps::Control));
+                        // TODO(Jacob): We should refine the control flow check
+                        // For instance, we could sink the StoreField instruction into failed guards
+                        // This allows us to preserve the dead store optimization.
                         if insn_reads_memory || insn_uses_control_flow {
                             compile_time_heap.clear();
                         }