Forbid some lints

Author: jesse-shopify

Cargo.toml

@@ -52,9 +52,9 @@ lto = "thin"
 
 [workspace.lints.clippy]
 # See: https://doc.rust-lang.org/clippy/lints.html
-correctness = { level = "deny", priority = 1 }
-suspicious = { level = "deny", priority = 1 }
-perf = { level = "deny", priority = 1 }
+correctness = { level = "forbid", priority = 1 }
+suspicious = { level = "forbid", priority = 1 }
+perf = { level = "forbid", priority = 1 }
 
 complexity = { level = "deny", priority = -1 }
 
@@ -66,5 +66,5 @@ identity_op = "allow"
 type_complexity = "allow"
 missing_transmute_annotations = "allow"
 
-unwrap_or_default = "deny"
-ptr_arg = "deny"
+unwrap_or_default = "forbid"
+ptr_arg = "forbid"

yjit/src/cruby.rs

@@ -97,7 +97,7 @@ pub type size_t = u64;
 pub type RedefinitionFlag = u32;
 
 #[allow(dead_code)]
-#[allow(clippy::all)]
+#[allow(clippy::complexity)]
 mod autogened {
     use super::*;
     // Textually include output from rust-bindgen as suggested by its user guide.

zjit/src/cruby.rs

@@ -103,6 +103,7 @@ pub type RedefinitionFlag = u32;
 
 #[allow(unsafe_op_in_unsafe_fn)]
 #[allow(dead_code)]
+#[allow(clippy::complexity)]
 mod autogened {
     use super::*;
     // Textually include output from rust-bindgen as suggested by its user guide.

zjit/src/hir.rs

@@ -947,12 +947,14 @@ pub enum ValidationError {
     DuplicateInstruction(BlockId, InsnId),
 }
 
+#[allow(clippy::needless_bool)]
 fn can_direct_send(iseq: *const rb_iseq_t) -> bool {
     if unsafe { rb_get_iseq_flags_has_rest(iseq) } { false }
     else if unsafe { rb_get_iseq_flags_has_opt(iseq) } { false }
     else if unsafe { rb_get_iseq_flags_has_kw(iseq) } { false }
     else if unsafe { rb_get_iseq_flags_has_kwrest(iseq) } { false }
-    else { !unsafe { rb_get_iseq_flags_has_block(iseq) } }
+    else if unsafe { rb_get_iseq_flags_has_block(iseq) } { false }
+    else { true }
 }
 
 /// A [`Function`], which is analogous to a Ruby ISeq, is a control-flow graph of [`Block`]s