Skip to content

Commit 9d8dbe5

Browse files
authored
Merge pull request #611 from Shopify/at-improve-review-skill
Improve review skill: suggest extracting repeated test setups into helpers
2 parents da78e16 + 7529679 commit 9d8dbe5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.claude/skills/review_changes/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Use the Rust and static analysis experts to review the code changes regarding th
1717
- Code quality and idiomatic patterns: does the code use idiomatic Rust? Are there opportunities to improve the code
1818
structure?
1919
- Performance: are there any performance pitfalls or opportunities for optimization?
20-
- Test coverage: are we missing scenarios?
20+
- Test coverage: are we missing scenarios? Are there repeated test setups that could be extracted into a test helper?
2121
- Documentation: are the key concepts clearly explained in the documentation (files under `docs` and README)?
2222
- Agent instructions: are there key concepts or major changes that should be reflected in AGENTS.md?
2323

0 commit comments

Comments
 (0)