Rename diagnostics to all_diagnostics

Author: thomasmarshall

rust/rubydex-sys/src/diagnostic_api.rs

@@ -43,7 +43,7 @@ impl DiagnosticArray {
 pub unsafe extern "C" fn rdx_graph_diagnostics(pointer: GraphPointer) -> *mut DiagnosticArray {
     with_graph(pointer, |graph| {
         let entries = graph
-            .diagnostics()
+            .all_diagnostics()
             .iter()
             .map(|diagnostic| {
                 let document = graph.documents().get(diagnostic.uri_id()).unwrap();

rust/rubydex/src/model/graph.rs

@@ -170,7 +170,7 @@ impl Graph {
     }
 
     #[must_use]
-    pub fn diagnostics(&self) -> Vec<&Diagnostic> {
+    pub fn all_diagnostics(&self) -> Vec<&Diagnostic> {
         let document_diagnostics = self.documents.values().flat_map(Document::diagnostics);
         let declaration_diagnostics = self.declarations.values().flat_map(Declaration::diagnostics);
         let definition_diagnostics = self.definitions.values().flat_map(Definition::diagnostics);
@@ -1035,10 +1035,10 @@ mod tests {
 
         // TODO: Add resolution error to test diagnostics attached to declarations
         context.index_uri("file:///foo.rb", "class Foo");
-        assert!(!context.graph().diagnostics().is_empty());
+        assert!(!context.graph().all_diagnostics().is_empty());
 
         context.index_uri("file:///foo.rb", "class Foo; end");
-        assert!(context.graph().diagnostics().is_empty());
+        assert!(context.graph().all_diagnostics().is_empty());
     }
 
     #[test]
@@ -1059,7 +1059,7 @@ mod tests {
 
         let mut diagnostics: Vec<String> = context
             .graph()
-            .diagnostics()
+            .all_diagnostics()
             .iter()
             .map(|d| {
                 format!(

rust/rubydex/src/resolution.rs

@@ -1757,7 +1757,7 @@ mod tests {
     fn format_diagnostics(context: &GraphTest, ignore_rules: &[Rule]) -> Vec<String> {
         let mut diagnostics: Vec<_> = context
             .graph()
-            .diagnostics()
+            .all_diagnostics()
             .into_iter()
             .filter(|d| !ignore_rules.contains(d.rule()))
             .collect();