Merge pull request #770 from Shopify/connieho/index-default-arg-constants

Index constant references in parameter default values

Author: vinistock

rust/rubydex/src/indexing/ruby_indexer.rs

@@ -234,6 +234,7 @@ impl<'a> RubyIndexer<'a> {
                     Offset::from_prism_location(&name_loc),
                     str_id,
                 )));
+                self.visit(&opt_param.value());
             }
 
             if let Some(rest) = parameters_list.rest() {
@@ -276,6 +277,7 @@ impl<'a> RubyIndexer<'a> {
                         let str_id = self.local_graph.intern_string(self.offset_to_string(&offset));
 
                         parameters.push(Parameter::OptionalKeyword(ParameterStruct::new(offset, str_id)));
+                        self.visit(&optional.value());
                     }
                     _ => {}
                 }

rust/rubydex/src/indexing/ruby_indexer_tests.rs

@@ -4060,6 +4060,19 @@ mod constant_reference_tests {
         );
     }
 
+    #[test]
+    fn index_unresolved_constant_references_in_default_values() {
+        let context = index_source({
+            "
+            def foo(a = C1, b = C2::C3); end
+            def bar(a: C4, b: C5::C6); end
+            "
+        });
+
+        assert_no_local_diagnostics!(&context);
+        assert_constant_references_eq!(&context, ["C1", "C2", "C3", "C4", "C5", "C6"]);
+    }
+
     #[test]
     fn index_constant_path_and_write_visits_value() {
         let context = index_source({