Merged
Conversation
vinistock
commented
May 5, 2026
| Some(Receiver::SelfReceiver(def_id)) => { | ||
| return self.find_self_receiver_declaration(*def_id, *it.new_name_str_id()); | ||
| } | ||
| Some(Receiver::ConstantReceiver(name_id)) => Some(name_id), |
Member
Author
There was a problem hiding this comment.
We were not handling constant receivers (e.g.: Foo.alias_method :bar, :baz), which ended up being surfaced in the new tests.
soutaro
reviewed
May 7, 2026
vinistock
force-pushed
the
05-04-add_follow_method_alias_query
branch
from
ecf65ea to
ffa0cfc
Compare
Co-authored-by: Soutaro Matsumoto <soutaro@users.noreply.github.com>
vinistock
force-pushed
the
05-04-add_follow_method_alias_query
branch
from
ffa0cfc to
73442de
Compare
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts a portion of #697
The PR implements
follow_method_alias, which accepts adefinition_idfor an alias and follows the chain until reaching the first concrete method definition. This is required to exposeMethodDefinition#signaturesin the Ruby API (as the definition may be an alias).This PR also moves the core logic of finding members in the ancestor chain to
query.rs, so that we can reuse it for this implementation and for the FFI.