Add max-line-length CLI option

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>

Author: Morriar

lib/spoom/cli/srb/sigs.rb

@@ -16,15 +16,26 @@ class Sigs < Thor
           desc: "Use positional names when translating from RBI to RBS",
           default: true
         option :include_rbi_files, type: :boolean, desc: "Include RBI files", default: false
+        option :max_line_length, type: :numeric, desc: "Max line length (pass 0 to disable)", default: 120
         def translate(*paths)
           from = options[:from]
           to = options[:to]
+          max_line_length = options[:max_line_length]
 
           if from == to
             say_error("Can't translate signatures from `#{from}` to `#{to}`")
             exit(1)
           end
 
+          if max_line_length.nil? || max_line_length.zero?
+            max_line_length = nil
+          elsif max_line_length.negative?
+            say_error("--max-line-length can't be negative")
+            exit(1)
+          else
+            max_line_length = max_line_length.to_i
+          end
+
           files = collect_files(paths, include_rbi_files: options[:include_rbi_files])
 
           say("Translating signatures from `#{from}` to `#{to}` " \
@@ -33,11 +44,20 @@ def translate(*paths)
           case from
           when "rbi"
             transformed_files = transform_files(files) do |file, contents|
-              Spoom::Sorbet::Translate.sorbet_sigs_to_rbs_comments(contents, file: file, positional_names: options[:positional_names])
+              Spoom::Sorbet::Translate.sorbet_sigs_to_rbs_comments(
+                contents,
+                file: file,
+                positional_names: options[:positional_names],
+                max_line_length: max_line_length,
+              )
             end
           when "rbs"
             transformed_files = transform_files(files) do |file, contents|
-              Spoom::Sorbet::Translate.rbs_comments_to_sorbet_sigs(contents, file: file)
+              Spoom::Sorbet::Translate.rbs_comments_to_sorbet_sigs(
+                contents,
+                file: file,
+                max_line_length: max_line_length,
+              )
             end
           end
 

test/spoom/cli/srb/sigs_test.rb

@@ -206,6 +206,62 @@ def foo; end
           RB
         end
 
+        def test_translate_to_rbs_with_max_line_length_error
+          result = @project.spoom("srb sigs translate --no-color --max-line-length -1")
+
+          assert_equal(<<~ERR, result.err)
+            Error: --max-line-length can't be negative
+          ERR
+          refute(result.status)
+        end
+
+        def test_translate_to_rbs_with_max_line_length_by_default
+          @project.write!("file.rb", <<~RB)
+            sig do
+              params(
+                param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType,
+                param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType
+              ).void
+            end
+            def foo(param1:, param2:); end
+          RB
+
+          result = @project.spoom("srb sigs translate --no-color")
+
+          assert_empty(result.err)
+          assert(result.status)
+
+          assert_equal(<<~RB, @project.read("file.rb"))
+            #: (
+            #|   param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType,
+            #|   param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType
+            #| ) -> void
+            def foo(param1:, param2:); end
+          RB
+        end
+
+        def test_translate_to_rbs_without_max_line_length
+          @project.write!("file.rb", <<~RB)
+            sig do
+              params(
+                param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType,
+                param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType
+              ).void
+            end
+            def foo(param1:, param2:); end
+          RB
+
+          result = @project.spoom("srb sigs translate --no-color --max-line-length 0")
+
+          assert_empty(result.err)
+          assert(result.status)
+
+          assert_equal(<<~RB, @project.read("file.rb"))
+            #: (param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType, param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType) -> void
+            def foo(param1:, param2:); end
+          RB
+        end
+
         # translate --from rbs --to rbi
 
         def test_translate_from_rbs_to_rbi
@@ -230,6 +286,51 @@ def foo; end
           RB
         end
 
+        def test_translate_to_rbi_with_max_line_length_by_default
+          @project.write!("file.rb", <<~RB)
+            #: (
+            #|   param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType,
+            #|   param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType
+            #| ) -> void
+            def foo(param1:, param2:); end
+          RB
+
+          result = @project.spoom("srb sigs translate --no-color --from rbs --to rbi")
+
+          assert_empty(result.err)
+          assert(result.status)
+
+          assert_equal(<<~RB, @project.read("file.rb"))
+            sig do
+              params(
+                param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType,
+                param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType
+              ).void
+            end
+            def foo(param1:, param2:); end
+          RB
+        end
+
+        def test_translate_to_rbi_without_max_line_length
+          @project.write!("file.rb", <<~RB)
+            #: (
+            #|   param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType,
+            #|   param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType
+            #| ) -> void
+            def foo(param1:, param2:); end
+          RB
+
+          result = @project.spoom("srb sigs translate --no-color --from rbs --to rbi --max-line-length 0")
+
+          assert_empty(result.err)
+          assert(result.status)
+
+          assert_equal(<<~RB, @project.read("file.rb"))
+            sig { params(param1: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType, param2: AVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongType).void }
+            def foo(param1:, param2:); end
+          RB
+        end
+
         # export
 
         def test_export_no_gemspec