Merge pull request #754 from Shopify/test-type-simplify-normalize

Tests for simplifying and normalizing types in sigs during translation

Author: jesse-shopify

Gemfile.lock

@@ -52,10 +52,9 @@ GEM
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.3.0)
-    rbi (0.3.3)
+    rbi (0.3.5)
       prism (~> 1.0)
       rbs (>= 3.4.4)
-      sorbet-runtime (>= 0.5.9204)
     rbs (4.0.0.dev.4)
       logger
       prism (>= 1.3.0)

test/spoom/sorbet/translate/sorbet_sigs_to_rbs_comments_test.rb

@@ -336,6 +336,54 @@ def foo
           RBS
         end
 
+        def test_translate_to_rbs_with_nested_nilable_param
+          contents = <<~RB
+            Class.new do
+              sig { params(x: T.nilable(T.nilable(Integer))).void }
+              def foo(x); end
+            end
+          RB
+
+          assert_equal(<<~RBS, sorbet_sigs_to_rbs_comments(contents))
+            Class.new do
+              #: (Integer? x) -> void
+              def foo(x); end
+            end
+          RBS
+        end
+
+        def test_translate_to_rbs_with_nested_any_param
+          contents = <<~RB
+            Class.new do
+              sig { params(x: T.any(T.any(Integer, String), Float, Integer)).void }
+              def foo(x); end
+            end
+          RB
+
+          assert_equal(<<~RBS, sorbet_sigs_to_rbs_comments(contents))
+            Class.new do
+              #: ((Integer | String | Float) x) -> void
+              def foo(x); end
+            end
+          RBS
+        end
+
+        def test_translate_to_rbs_with_nested_all_param
+          contents = <<~RB
+            Class.new do
+              sig { params(x: T.all(T.all(Enumerable, Comparable), Numeric, Enumerable)).void }
+              def foo(x); end
+            end
+          RB
+
+          assert_equal(<<~RBS, sorbet_sigs_to_rbs_comments(contents))
+            Class.new do
+              #: ((Enumerable & Comparable & Numeric) x) -> void
+              def foo(x); end
+            end
+          RBS
+        end
+
         private
 
         #: (String, ?positional_names: bool) -> String