Skip to content

Commit 6567f26

Browse files
committed
Extract AnyScopeNode type alias
1 parent ab878c8 commit 6567f26

4 files changed

Lines changed: 12 additions & 6 deletions

File tree

lib/spoom/sorbet/metrics/code_metrics_visitor.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def visit_call_node(node)
147147

148148
private
149149

150-
#: (Prism::ClassNode | Prism::ModuleNode | Prism::SingletonClassNode) { -> void } -> void
150+
#: (Prism::AnyScopeNode) { -> void } -> void
151151
def visit_scope(node, &block)
152152
key = node_key(node)
153153
@counters.increment(key)
@@ -216,7 +216,7 @@ def collect_last_srb_sigs
216216
sigs
217217
end
218218

219-
#: (Prism::ClassNode | Prism::ModuleNode | Prism::SingletonClassNode) -> String
219+
#: (Prism::AnyScopeNode) -> String
220220
def node_key(node)
221221
case node
222222
when Prism::ClassNode

lib/spoom/sorbet/translate/rbs_comments_to_sorbet_sigs/base_translator.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def apply_overloads_strategy(signatures, method_name:, location:)
199199
end
200200
end
201201

202-
#: (Prism::ClassNode | Prism::ModuleNode | Prism::SingletonClassNode) -> void
202+
#: (Prism::AnyScopeNode) -> void
203203
def apply_class_annotations(node)
204204
comments = node_rbs_comments(node)
205205
return if comments.empty?
@@ -324,7 +324,7 @@ def apply_member_annotations(annotations, sig)
324324
end
325325
end
326326

327-
#: (Prism::ClassNode | Prism::ModuleNode | Prism::SingletonClassNode, Regexp) -> bool
327+
#: (Prism::AnyScopeNode, Regexp) -> bool
328328
def already_extends?(node, constant_regex)
329329
node.child_nodes.any? do |c|
330330
next false unless c.is_a?(Prism::CallNode)

lib/spoom/sorbet/translate/sorbet_sigs_to_rbs_comments.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def visit_constant_write_node(node)
134134

135135
private
136136

137-
#: (Prism::ClassNode | Prism::ModuleNode | Prism::SingletonClassNode) { -> void } -> void
137+
#: (Prism::AnyScopeNode) { -> void } -> void
138138
def visit_scope(node, &block)
139139
old_class_annotations = @class_annotations
140140
@class_annotations = []
@@ -229,7 +229,7 @@ def visit_extend(node)
229229
end
230230
end
231231

232-
#: (Prism::ClassNode | Prism::ModuleNode | Prism::SingletonClassNode, Prism::CallNode) -> void
232+
#: (Prism::AnyScopeNode, Prism::CallNode) -> void
233233
def apply_class_annotation(parent, node)
234234
unless node.message == "abstract!" || node.message == "interface!" || node.message == "sealed!" ||
235235
node.message == "final!" || node.message == "requires_ancestor"

sorbet/rbi/shims/prism.rbi

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# typed: strict
2+
# frozen_string_literal: true
3+
4+
module Prism
5+
AnyScopeNode = T.type_alias { T.any(Prism::ClassNode, Prism::ModuleNode, Prism::SingletonClassNode) }
6+
end

0 commit comments

Comments
 (0)