Do not translate Sorbet assertions in ternary expressions

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>

Author: Morriar

lib/spoom/sorbet/translate/sorbet_assertions_to_rbs_comments.rb

@@ -8,6 +8,27 @@ module Translate
       class SorbetAssertionsToRBSComments < Translator
         LINE_BREAK = "\n".ord #: Integer
 
+        # @override
+        #: (Prism::IfNode) -> void
+        def visit_if_node(node)
+          if node.if_keyword_loc
+            # We do not translate assertions in ternary expressions to avoid altering the semantic of the code.
+            #
+            # For example:
+            # ```rb
+            # a = T.must(b) ? T.must(c) : T.must(d)
+            # ```
+            #
+            # would become
+            # ```rb
+            # a = T.must(b) ? T.must(c) : d #: !nil
+            # ```
+            #
+            # which does not match the original intent.
+            super
+          end
+        end
+
         # @override
         #: (Prism::CallNode) -> void
         def visit_call_node(node)

test/spoom/sorbet/translate/sorbet_assertions_to_rbs_comments_test.rb

@@ -482,6 +482,14 @@ def test_doesnt_translate_cast_in_string_interpolation
           assert_equal(rb, rbi_to_rbs(rb))
         end
 
+        def test_doesnt_translate_in_ternary_expressions
+          rb = <<~RB
+            a = T.must(b) ? T.must(c) : T.must(d)
+          RB
+
+          assert_equal(rb, rbi_to_rbs(rb))
+        end
+
         private
 
         #: (String) -> String