Merge pull request #766 from Shopify/at-rbs-abstract

Raise `NotImplementedError` from abstract methods

Author: Morriar

lib/spoom/coverage/d3/base.rb

@@ -42,7 +42,7 @@ def tooltip
 
         # @abstract
         #: -> String
-        def script = raise("Abstract method called")
+        def script = raise NotImplementedError, "Abstract method called"
       end
     end
   end

lib/spoom/coverage/d3/timeline.rb

@@ -119,7 +119,7 @@ def script
 
         # @abstract
         #: -> String
-        def plot = raise("Abstract method called")
+        def plot = raise NotImplementedError, "Abstract method called"
 
         #: -> String
         def x_scale

lib/spoom/coverage/report.rb

@@ -70,7 +70,7 @@ def body_html
 
       # @abstract
       #: -> Array[Cards::Card]
-      def cards = raise("Abstract method called")
+      def cards = raise NotImplementedError, "Abstract method called"
 
       #: -> String
       def footer_html
@@ -106,7 +106,7 @@ def html
 
         # @abstract
         #: -> String
-        def erb = raise("Abstract method called")
+        def erb = raise NotImplementedError, "Abstract method called"
       end
 
       class Snapshot < Card

lib/spoom/sorbet/lsp/structures.rb

@@ -10,7 +10,7 @@ module LSP
     module PrintableSymbol
       # @abstract
       #: (SymbolPrinter printer) -> void
-      def accept_printer(printer) = raise("Abstract method called")
+      def accept_printer(printer) = raise NotImplementedError, "Abstract method called"
     end
 
     class Hover < T::Struct

lib/spoom/source/rewriter.rb

@@ -29,11 +29,11 @@ class PositionError < Spoom::Error; end
     class Edit
       # @abstract
       #: (Array[Integer]) -> void
-      def apply(bytes) = raise("Abstract method called")
+      def apply(bytes) = raise NotImplementedError, "Abstract method called"
 
       # @abstract
       #: -> [Integer, Integer]
-      def range = raise("Abstract method called")
+      def range = raise NotImplementedError, "Abstract method called"
     end
 
     class Insert < Edit