Fix spoom srb assertions translate to preserve trailing comments in correct order#803
Merged
Conversation
…orrect order When translating T.let with trailing comments, the RBS annotation now appears before the comment so Sorbet can properly recognize the type: a = T.let(3, Integer) # comment now translates to: a = 3 #: Integer # comment instead of: a = 3 # comment #: Integer 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
burke
force-pushed
the
comments-and-types
branch
from
1ef1233 to
79fbc5b
Compare
Member
Author
|
egh I guess I messed up a test, I'll see when I get some time to debug that. |
Member
Author
|
Oh interesting, it was failing on main too. Well I pushed a fix I think. |
egiurleo
approved these changes
Oct 8, 2025
Contributor
|
|
Member
Author
|
Whoops! Fixed, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When translating T.let with trailing comments, the RBS annotation now appears before the comment so Sorbet can properly recognize the type:
now translates to:
instead of: