Use bundle-locked gem versions in child contexts

[amomchilov]

Fixes CI in other projects, like https://github.com/Shopify/rbi/actions/runs/19509877786/job/55846512135?pr=534

[amomchilov]

Would this explanation be clear to someone who didn't already understand what's going on here?

[Morriar]

I don't think we really care which version of Sorbet gets installed in these tests?

[amomchilov]

I don't think so either, but I'd rather not have to worry about it.

[Morriar]

Same here, I don't think we really care about which version we use

[Morriar]

This is such a convoluted way to express something simple:

Suggested change

	if 1 < specs.count
	raise <<~MSG
	Found multiple versions of #{gem_name.inspect} in the current bundle:
	#{specs.sort_by(&:version).map { |spec| " - #{spec.name} #{spec.version}" }.join("\n")}
	MSG
	end
	unless (spec = specs.first)
	raise "Did not find gem #{gem_name.inspect} in the current bundle"
	end
	%(gem "#{spec.name}", "= #{spec.version}")
	if specs.count < 1
	raise "Did not find gem #{gem_name.inspect} in the current bundle"
	elsif specs.count > 1
	raise <<~MSG
	Found multiple versions of #{gem_name.inspect} in the current bundle:
	#{specs.sort_by(&:version).map { |spec| " - #{spec.name} #{spec.version}" }.join("\n")}
	MSG
	else
	%(gem "#{spec.name}", "= #{spec.version}")
	end

[amomchilov]

You forgot spec = specs.first, but then that doesn't typecheck because it's nilable, so you need a #: !nil...

And it turns out about the same.

[Morriar]

So something like this?

        specs = Bundler.load.gems[gem_name]

        if specs.nil? || specs.empty?
          raise "Did not find gem #{gem_name.inspect} in the current bundle"
        elsif specs.count > 1
          raise <<~MSG
            Found multiple versions of #{gem_name.inspect} in the current bundle:
            #{specs.sort_by(&:version).map { |spec| "  - #{spec.name} #{spec.version}" }.join("\n")}
          MSG
        else
          spec = specs.first
          %(gem "#{spec.name}", "= #{spec.version}")
        end

[amomchilov]

Yes, except it would need spec = specs.first #: !nil, which is worse. Turns out we don't need it, because Bundler.load is untyped 😅

[Morriar]

it would need spec = specs.first #: !nil, which is worse

Is it really now that it's a comment? Only the static checker has to do additional work, the runtime stays unchanged.

[amomchilov]

It's a matter of personal taste, I prefer the if (x = a.first) to check a.count > 1 and get the first in a single shot. Won't someone think of the branches?! :D