Merge pull request #2424 from Shopify/uk-fix-module-patching

Fully qualify references to top-level `Module`

Author: paracycle

lib/tapioca/runtime/trackers/required_ancestor.rb

@@ -52,7 +52,7 @@ def required_ancestors_by(mod)
 
 module T
   module Helpers
-    prepend(Module.new do
+    prepend(::Module.new do
       def requires_ancestor(&block)
         # We can't directly call the block since the ancestor might not be loaded yet.
         # We save the block in the map and will resolve it later.

lib/tapioca/sorbet_ext/generic_name_patch.rb

@@ -22,7 +22,7 @@ def type_member(variance = :invariant, &bounds_proc)
         # `T::Generic#type_member` just instantiates a `T::Type::TypeMember` instance and returns it.
         # We use that when registering the type member and then later return it from this method.
         Tapioca::TypeVariableModule.new(
-          T.cast(self, Module),
+          T.cast(self, ::Module),
           Tapioca::TypeVariableModule::Type::Member,
           variance,
           bounds_proc,
@@ -35,7 +35,7 @@ def type_template(variance = :invariant, &bounds_proc)
         # `T::Generic#type_template` just instantiates a `T::Type::TypeTemplate` instance and returns it.
         # We use that when registering the type template and then later return it from this method.
         Tapioca::TypeVariableModule.new(
-          T.cast(self, Module),
+          T.cast(self, ::Module),
           Tapioca::TypeVariableModule::Type::Template,
           variance,
           bounds_proc,
@@ -48,7 +48,7 @@ def has_attached_class!(variance = :invariant, &bounds_proc)
         Tapioca::Runtime::GenericTypeRegistry.register_type_variable(
           self,
           Tapioca::TypeVariableModule.new(
-            T.cast(self, Module),
+            T.cast(self, ::Module),
             Tapioca::TypeVariableModule::Type::HasAttachedClass,
             variance,
             bounds_proc,

lib/tapioca/sorbet_ext/name_patch.rb

@@ -5,24 +5,13 @@ module T
   module Types
     class Simple
       module NamePatch
-        NAME_METHOD = Module.instance_method(:name) #: UnboundMethod
-
         def name
           # Sorbet memoizes this method into the `@name` instance variable but
           # doing so means that types get memoized before this patch is applied
-          qualified_name_of(@raw_type)
-        end
-
-        def qualified_name_of(constant)
-          name = NAME_METHOD.bind_call(constant)
-          name = nil if name&.start_with?("#<")
-          return "::T.untyped" if name.nil?
+          name = Tapioca::Runtime::Reflection.qualified_name_of(@raw_type)
+          name = "::T.untyped" if name.nil?
 
-          if name.start_with?("::")
-            name
-          else
-            "::#{name}"
-          end
+          name
         end
       end