Merge pull request #2571 from Shopify/Alex/fix-assert_raises-calls

Fix `assert_raises` calls

Author: amomchilov

spec/tapioca/dsl/compiler_spec.rb

@@ -191,7 +191,7 @@ def decorate
                     klass.create_method(
                       method.name.to_s,
                       parameters: [],
-                      return_type: "void)",
+                      return_type: "void)", # intentional mistake, leading to `sig { returns(void)) }`
                       class_method: false,
                     )
                   end
@@ -220,9 +220,10 @@ def foo(d:, e: 42, **f, &blk); end
             end
           RUBY
 
-          assert_raises(SyntaxError, /void\)/) do
-            rbi_for(:Post)
-          end
+          e = assert_raises(SyntaxError) { rbi_for(:Post) }
+
+          assert_match('unexpected token ")"', e.message)
+          assert_match("sig { returns(void)) }", e.message)
         end
       end
     end

spec/tapioca/dsl/compilers/json_api_client_resource_spec.rb

@@ -178,9 +178,9 @@ class Post < JsonApiClient::Resource
               # We let the generation raise, the user should not define an association without a corresponding class.
               # The association will be unusable anyway.
 
-              assert_raises(NameError, /uninitialized constant Post::User/) do
-                rbi_for(:Post)
-              end
+              e = assert_raises(NameError) { rbi_for(:Post) }
+
+              assert_match(/uninitialized constant Post::User/, e.message)
             end
 
             it "generates associations" do

spec/tapioca/helpers/sorbet_helper_spec.rb

@@ -28,7 +28,7 @@ class Tapioca::SorbetHelperSpec < Minitest::Spec
     end
 
     it "raises for an unknown feature check" do
-      assert_raises do
+      assert_raises(RuntimeError) do
         sorbet_supports?(:unknown_feature_name)
       end
     end