Filter Rubydex declarations to namespaces, constants, and aliases

Author: Morriar

lib/tapioca/gem/pipeline.rb

@@ -32,7 +32,7 @@ def initialize(
 
         @payload_symbols = Static::SymbolLoader.payload_symbols #: Set[String]
         gem_graph = Static::SymbolLoader.graph_from_paths(@gem.files) #: Rubydex::Graph
-        gem_symbols = gem_graph.declarations.map(&:name).to_set
+        gem_symbols = Static::SymbolLoader.symbols_from_graph(gem_graph)
         engine_symbols = Static::SymbolLoader.engine_symbols(@gem)
         @bootstrap_symbols = gem_symbols.union(engine_symbols) #: Set[String]
 

lib/tapioca/static/symbol_loader.rb

@@ -26,6 +26,28 @@ def graph_from_paths(paths)
           graph
         end
 
+        #: (Rubydex::Graph graph) -> Set[String]
+        def symbols_from_graph(graph)
+          graph.declarations.filter_map do |decl|
+            next unless decl.is_a?(Rubydex::Namespace) ||
+              decl.is_a?(Rubydex::Constant) ||
+              decl.is_a?(Rubydex::ConstantAlias) ||
+              decl.is_a?(Rubydex::Todo)
+
+            # Declarations added by `graph.resolve` only have `rubydex:built-in` definitions.
+            # We exclude those unless the namespace has method or constant members defined in
+            # source files, which indicates a class reopening (e.g. `class Object; def Nokogiri(); end`).
+            if decl.definitions.any? && decl.definitions.all? { |defn| defn.location.uri == "rubydex:built-in" }
+              next unless decl.is_a?(Rubydex::Namespace) && decl.members.any? do |m|
+                (m.is_a?(Rubydex::Method) || m.is_a?(Rubydex::Constant) || m.is_a?(Rubydex::ConstantAlias)) &&
+                  m.definitions.any?
+              end
+            end
+
+            decl.name
+          end.to_set
+        end
+
         #: (Gemfile::GemSpec gem) -> Set[String]
         def engine_symbols(gem)
           gem_engine = engines.find do |engine|
@@ -47,7 +69,7 @@ def engine_symbols(gem)
           end
 
           engine_graph = graph_from_paths(paths)
-          engine_graph.declarations.map(&:name).to_set
+          symbols_from_graph(engine_graph)
         rescue
           Set.new
         end