Remove NilClass parameters from AR fixture methods#2660
Merged
Conversation
b9bc5a7 to
b3088e5
Compare
KaanOzkan
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixture methods have 3 overloads to describe the different ways they can be called. Their current shape incorrectly allows to nils to be passed, like:
This PR fixes these annotations to not allow such
nils, which has the pleasant side-effect of making them much simpler.See also #1871, #1895
Implementation
Uses the same approach I used to describe
Module#private(sorbet/sorbet#10239).Tests
Updated.
Validated against Shopify Core. Type-checking fails, but for a great reason: there's a few of new errors like: