GH workflow needs to be manually triggered to update latest.json revision#1004
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7841df5 to
3b5f02e
Compare
There was a problem hiding this comment.
Thank you for this PR, @aswamy!
Since we're aiming to create a pull request now, do you think we should change what triggers this workflow?
If we leave it as is, it seems like a new PR would be created on every commit, including when we merge the data/latest.json PR itself.
Maybe we could set this workflow to be triggered manually instead, or set the revision value using a different approach to prevent the creation of too many PRs. What do you think?
Wouldn't this only be created if we merge to main? Also this only creates the PR IF it needs to be created since we have the I guess if we forget to merge one, we can see a lot of these PRs pile up 🤔 |
As soon as we merge a PR updating Am I missing something? @aswamy, please, feel free to proceed with the merge, if you'd like to validate that assumption :) |
|
One question around this - why do we have to make a separate PR when Ai files need to be updated? Can't we just fail the CI for PRs and tell the user "hey, run |
3b5f02e to
25acf84
Compare
|
Ignore my previous comment. Just for simplicity i updated the workflow so it can be manually triggered like you originally said. |
25acf84 to
8cba45a
Compare

TL;DR
Changed the GitHub workflow to create pull requests for AI documentation updates instead of directly pushing to main.
What changed?
update-latest.ymlworkflow to create a pull request for changes instead of pushing directly to mainupdate-ai-docs-YYYYMMDD-HHMMSS)How to test?
ai/liquid.mdcanddata/latest.jsonExample run: https://github.com/Shopify/theme-liquid-docs/actions/runs/16679895368/job/47215746922
⚠️ NOTE: It also contains the file in this PR since it branches off of main. You can ignore this commit in that PR, only see the changes to
Example PR created: #1023
ai/liquid.mdcanddata/latest.jsonWhy make this change?
This change improves the workflow by creating pull requests instead of direct commits to main, which: