Add color_palette setting type#1565
Merged
Merged
Conversation
Add color_palette as a valid setting type in the theme settings JSON schema. This allows themes to use color_palette settings without triggering ValidJSON errors in theme-check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
graygilmore
approved these changes
Apr 7, 2026
| "color_background", | ||
| "color_scheme", | ||
| "color_scheme_group", | ||
| "color_palette", |
Contributor
There was a problem hiding this comment.
Looks like we’re off a little bit on the alphabetically ordering through the file.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add color_palette to the accepted theme settings types. Update test files as needed.
tests/test-constants.ts— addcolor_palettetoINPUT_SETTING_TYPEStests/fixtures/theme-settings-all-settings.json— add fixture entry to validate the schema definition