fix: use createRequire for node_modules resolution in VSCode extension (#1171)

* fix: use createRequire for node_modules resolution in VSCode extension

The VSCode extension server is bundled with webpack, which replaces
`require` with its own module system. webpack's `require.resolve` does
not support the `paths` option and returns a numeric module ID rather
than a file path, causing "Cannot find module" errors for custom check
packages (e.g. `@grafikr/theme-check-extension/recommended.yml`).

Replace `require.resolve(pathLike, { paths: getAncestorNodeModules(root) })`
with `createRequire` from `node:module`, which creates a real Node.js
require function that bypasses webpack's substitution. Node.js's native
module resolution already traverses ancestor node_modules directories
automatically, so `getAncestorNodeModules` is no longer needed.

Fixes #1170

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: add changeset for node_modules resolution fix

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Update packages/theme-check-node/src/config/resolve/read-yaml.ts

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: andershagbard

.changeset/fix-vscode-node-modules-resolution.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme-check-node': patch
+---
+
+Fix VSCode extension failing to resolve custom check packages from node_modules (e.g. `extends: '@acme/theme-check-extension/recommended.yml'`). The extension server is webpack-bundled, so `require.resolve` was being handled by webpack instead of Node.js, returning a module ID rather than a file path. Now uses `createRequire` from `node:module` to get real Node.js resolution.

packages/theme-check-node/src/config/resolve/read-yaml.ts

@@ -1,6 +1,7 @@
 import { CheckSettings, Modes, Severity } from '@shopify/theme-check-common';
 import { realpathSync } from 'node:fs';
 import fs from 'node:fs/promises';
+import { createRequire } from 'node:module';
 import path from 'node:path';
 import { parse } from 'yaml';
 import { AbsolutePath } from '../../temp';
@@ -172,7 +173,14 @@ function resolvePath(
     return path.resolve(root, pathLike);
   }
 
-  return realpathSync(require.resolve(pathLike, { paths: getAncestorNodeModules(root)! }));
+  // Use createRequire to get the real Node.js require rather than webpack's
+  // substitute. When the VSCode extension server is bundled, `require.resolve`
+  // becomes webpack's version which doesn't support the `paths` option and
+  // returns a numeric module ID instead of a file path. createRequire creates
+  // a real Node.js require function that resolves from the given directory,
+  // traversing ancestor node_modules automatically.
+  const req = createRequire(path.join(root, '__placeholder'));
+  return realpathSync(req.resolve(pathLike));
 }
 
 /**
@@ -237,15 +245,3 @@ function isString(thing: unknown): thing is string {
 function asArray<T>(thing: T | T[]): T[] {
   return Array.isArray(thing) ? thing : [thing];
 }
-
-function getAncestorNodeModules(dir: string): string[] {
-  const root = path.parse(dir).root;
-  const nodeModulesPaths: string[] = [];
-
-  while (dir !== root) {
-    nodeModulesPaths.push(path.join(dir, 'node_modules'));
-    dir = path.dirname(dir);
-  }
-
-  return nodeModulesPaths;
-}