Address admin app home review comments

Author: JoviDeCroock

packages/ui-extensions-tester/README.md

@@ -401,7 +401,7 @@ Imports and executes the extension module's default export, rendering the extens
 
 A mock `shopify` global, typed correctly for the target under test. You can mutate any property.
 
-When testing `admin.app.home.render`, the mock `shopify` object also includes `toast`, `app`, and `loading()`.
+When testing `admin.app.home.render`, the mock `shopify` object also includes `toast`, `app`, `loading()`, `tools`, and `intents.request`.
 
 When testing `admin.app.intent.render`, the mock `shopify.intents` object also includes `response.ok()`, `response.error()`, and `response.closed()`.
 

packages/ui-extensions-tester/src/admin/README.md

@@ -25,7 +25,7 @@ extension.shopify.storage = createStorage({
 
 ## 🏠 App home mocks
 
-The `admin.app.home.render` target mock includes `shopify.toast`, `shopify.app`, and `shopify.loading()`.
+The `admin.app.home.render` target mock includes `shopify.toast`, `shopify.app`, `shopify.loading()`, `shopify.tools`, and `shopify.intents.request`.
 
 ## 🧭 App intent mocks
 

packages/ui-extensions-tester/src/admin/factories.ts

@@ -134,14 +134,16 @@ function createMockToolsApi(): Tools {
 }
 
 function createAppHomeMock<T extends ExtensionTarget>(target: T) {
+  const {invoke} = createMockStandardApi(target).intents;
+
   return {
     ...createMockStandardRenderingApi(target),
     toast: createMockToastApi(),
     app: createMockAppApi(),
     loading: createMockLoadingApi(),
     tools: createMockToolsApi(),
     intents: {
-      ...createMockStandardApi(target).intents,
+      invoke,
       request: {
         value: null,
         subscribe: () => () => {},

packages/ui-extensions-tester/src/tests/admin-app-home-intents.test.ts

@@ -8,19 +8,12 @@ import type {
 } from '@shopify/ui-extensions/admin';
 
 import {createMockAdminTargetApi} from '../admin/factories';
+import {assertType, type Equals} from './type-assertions';
 
 // ---------------------------------------------------------------------------
 // Compile-time assertions
 // ---------------------------------------------------------------------------
 
-type Equals<A, B> = (<T>() => T extends A ? 1 : 2) extends <T>() => T extends B
-  ? 1
-  : 2
-  ? true
-  : false;
-
-function assertType<_T extends true>() {}
-
 type AppHome = AppHomeApi<'admin.app.home.render'>;
 
 // AppHomeApi exposes a richer `Intents` shape than `StandardApi`: a signal-
@@ -29,9 +22,7 @@ type AppHome = AppHomeApi<'admin.app.home.render'>;
 assertType<Equals<AppHome['intents'], AppHomeIntents>>();
 assertType<Equals<AppHome['intents']['request'], AppHomeIntentRequest>>();
 
-// `AppHomeIntents` extends the base `Intents` so `launchUrl` and `invoke`
-// remain reachable.
-assertType<Equals<AppHomeIntents['launchUrl'], Intents['launchUrl']>>();
+// `AppHomeIntents` keeps the standard invocation helper.
 assertType<Equals<AppHomeIntents['invoke'], Intents['invoke']>>();
 
 // `WithGeneratedIntents` narrows `request.value` to the generated payload
@@ -74,11 +65,9 @@ describe('app home intents api', () => {
     expect(() => unsubscribe()).not.toThrow();
   });
 
-  it('exposes the standard `Intents` members alongside `request`', () => {
+  it('exposes the standard `invoke` helper alongside `request`', () => {
     const api = createMockAdminTargetApi('admin.app.home.render');
 
-    // `launchUrl` and `invoke` come from the base `Intents` shape.
-    expect(api.intents.launchUrl).toBeUndefined();
     expect(typeof api.intents.invoke).toBe('function');
   });
 });

packages/ui-extensions-tester/src/tests/admin-tools.test.ts

@@ -6,19 +6,12 @@ import type {
 } from '@shopify/ui-extensions/admin';
 
 import {createMockAdminTargetApi} from '../admin/factories';
+import {assertType, type Equals} from './type-assertions';
 
 // ---------------------------------------------------------------------------
 // Compile-time assertions
 // ---------------------------------------------------------------------------
 
-type Equals<A, B> = (<T>() => T extends A ? 1 : 2) extends <T>() => T extends B
-  ? 1
-  : 2
-  ? true
-  : false;
-
-function assertType<_T extends true>() {}
-
 interface UpdateFaqInput {
   id: string;
   body: string;

packages/ui-extensions-tester/src/tests/type-assertions.ts

@@ -0,0 +1,9 @@
+export type Equals<A, B> = (<T>() => T extends A ? 1 : 2) extends <
+  T,
+>() => T extends B ? 1 : 2
+  ? true
+  : false;
+
+export function assertType<_T extends true>(): void {
+  return undefined;
+}

packages/ui-extensions/src/surfaces/admin/api/app-home/app-home.ts

@@ -5,9 +5,9 @@ import type {AppApi} from '../app/app';
 import type {LoadingApi} from '../loading/loading';
 import type {Tools} from '../tools/tools';
 import type {
+  IntentInvokeApi,
   IntentQueryOptions,
   IntentResponseApi,
-  Intents,
 } from '../intents/intents';
 
 /**
@@ -38,14 +38,13 @@ export interface AppHomeIntentRequest {
 }
 
 /**
- * The intents API available to app home extensions. Extends the standard
- * `Intents` API with a signal-like `request` that streams link intents into
- * the long-running extension. `response` is only present while an intent is
- * active and is bound to the current `request.value`.
+ * The intents API available to app home extensions. It exposes a signal-like
+ * `request` that streams link intents into the long-running extension. Inspect
+ * `request.value` for information about the active intent.
  *
  * @publicDocs
  */
-export interface AppHomeIntents extends Intents {
+export interface AppHomeIntents {
   /**
    * The current link intent delivered to the extension. Subscribe to receive
    * new intents over the lifetime of the extension.
@@ -56,6 +55,10 @@ export interface AppHomeIntents extends Intents {
    * non-null; the runtime swaps in a fresh handle for each new intent.
    */
   response?: IntentResponseApi;
+  /**
+   * Launches an intent workflow for creating or editing Shopify resources.
+   */
+  invoke?: IntentInvokeApi;
 }
 
 /**