Skip to content

Commit 2caa91c

Browse files
committed
Fix remaining review items: min->minimum, policy/sms placement, autocomplete section, disabled wording
Made-with: Cursor
1 parent e0705ab commit 2caa91c

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

packages/ui-extensions/src/surfaces/checkout/components/components-shared.d.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1716,7 +1716,7 @@ export interface MinMaxLengthProps {
17161716
*/
17171717
maxLength?: number;
17181718
/**
1719-
* Specifies the min number of characters allowed.
1719+
* Specifies the minimum number of characters allowed.
17201720
*
17211721
* @default 0
17221722
*/
@@ -2042,6 +2042,9 @@ export interface AutocompleteProps<AutocompleteField extends AnyAutocompleteFiel
20422042
* Commonly used when there are multiple fields with the same autocomplete needs
20432043
* in the same page. For example: 2 shipping address forms in the same page.
20442044
*/
2045+
/**
2046+
* A named section that scopes the autocomplete data. Use to group related fields, such as separate billing and shipping addresses on the same form.
2047+
*/
20452048
export type AutocompleteSection = `section-${string}`;
20462049
/**
20472050
* The contact information group the autocomplete data should be sourced from.
@@ -2053,12 +2056,15 @@ export type AutocompleteGroup = "shipping" | "billing";
20532056
export type AutocompleteAddressGroup = "fax" | "home" | "mobile" | "pager";
20542057
export type AnyAutocompleteField = "additional-name" | "address-level1" | "address-level2" | "address-level3" | "address-level4" | "address-line1" | "address-line2" | "address-line3" | "country-name" | "country" | "current-password" | "email" | "family-name" | "given-name" | "honorific-prefix" | "honorific-suffix" | "language" | "name" | "new-password" | "nickname" | "one-time-code" | "organization-title" | "organization" | "photo" | "postal-code" | "sex" | "street-address" | "transaction-amount" | "transaction-currency" | "url" | "username" | "bday-day" | "bday-month" | "bday-year" | "bday" | "cc-additional-name" | "cc-expiry-month" | "cc-expiry-year" | "cc-expiry" | "cc-family-name" | "cc-given-name" | "cc-name" | "cc-number" | "cc-csc" | "cc-type" | `${AutocompleteAddressGroup} email` | "impp" | `${AutocompleteAddressGroup} impp` | "tel" | "tel-area-code" | "tel-country-code" | "tel-extension" | "tel-local-prefix" | "tel-local-suffix" | "tel-local" | "tel-national" | `${AutocompleteAddressGroup} tel` | `${AutocompleteAddressGroup} tel-area-code` | `${AutocompleteAddressGroup} tel-country-code` | `${AutocompleteAddressGroup} tel-extension` | `${AutocompleteAddressGroup} tel-local-prefix` | `${AutocompleteAddressGroup} tel-local-suffix` | `${AutocompleteAddressGroup} tel-local` | `${AutocompleteAddressGroup} tel-national`;
20552058
export type TextAutocompleteField = ExtractStrict<AnyAutocompleteField, "additional-name" | "address-level1" | "address-level2" | "address-level3" | "address-level4" | "address-line1" | "address-line2" | "address-line3" | "country-name" | "country" | "family-name" | "given-name" | "honorific-prefix" | "honorific-suffix" | "language" | "name" | "nickname" | "one-time-code" | "organization-title" | "organization" | "postal-code" | "sex" | "street-address" | "transaction-currency" | "username" | "cc-name" | "cc-given-name" | "cc-additional-name" | "cc-family-name" | "cc-type">;
2059+
/**
2060+
* The type of consent policy being collected.
2061+
*
2062+
* - `'sms-marketing'`: Represents the policy for SMS marketing consent.
2063+
*/
20562064
export type ConsentPolicy = "sms-marketing";
20572065
interface ConsentCheckboxProps$1 extends GlobalProps, CheckboxProps$1 {
20582066
/**
2059-
* The policy for which user consent is being collected for.
2060-
*
2061-
* `sms-marketing`: Represents the policy for SMS marketing consent.
2067+
* The policy for which user consent is being collected.
20622068
*/
20632069
policy?: ConsentPolicy;
20642070
}
@@ -2075,9 +2081,7 @@ interface PhoneFieldProps$1 extends GlobalProps, BaseTextFieldProps, Pick<FieldD
20752081
}
20762082
interface ConsentPhoneFieldProps$1 extends GlobalProps, PhoneFieldProps$1 {
20772083
/**
2078-
* The policy for which user consent is being collected for.
2079-
*
2080-
* `sms-marketing`: Represents the policy for SMS marketing consent.
2084+
* The policy for which user consent is being collected.
20812085
*/
20822086
policy?: ConsentPolicy;
20832087
}

0 commit comments

Comments
 (0)