Skip to content

Commit 7386990

Browse files
committed
fix: use window.addEventListener in deprecation messages, remove cart_update event reference
1 parent 872fc2e commit 7386990

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

packages/ui-extensions/src/surfaces/point-of-sale/extension-targets.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export interface EventExtensionTargets {
3333
* Fires when a transaction completes successfully.
3434
*
3535
* @deprecated Deprecated as of `2026-04`. Use `pos.app.ready.data` target with
36-
* `shopify.addEventListener('transaction_complete', callback)` instead.
36+
* `window.addEventListener('transaction_complete', callback)` instead.
3737
* See https://shopify.dev/docs/api/pos-ui-extensions/unstable/targets/pos-app-ready-data
3838
* @private
3939
*/
@@ -44,7 +44,7 @@ export interface EventExtensionTargets {
4444
* Fires when a cash tracking session starts.
4545
*
4646
* @deprecated Deprecated as of `2026-04`. Use `pos.app.ready.data` target with
47-
* `shopify.addEventListener('cash_tracking_session_start', callback)` instead.
47+
* `window.addEventListener('cash_tracking_session_start', callback)` instead.
4848
* See https://shopify.dev/docs/api/pos-ui-extensions/unstable/targets/pos-app-ready-data
4949
* @private
5050
*/
@@ -55,7 +55,7 @@ export interface EventExtensionTargets {
5555
* Fires when a cash tracking session completes.
5656
*
5757
* @deprecated Deprecated as of `2026-04`. Use `pos.app.ready.data` target with
58-
* `shopify.addEventListener('cash_tracking_session_complete', callback)` instead.
58+
* `window.addEventListener('cash_tracking_session_complete', callback)` instead.
5959
* See https://shopify.dev/docs/api/pos-ui-extensions/unstable/targets/pos-app-ready-data
6060
* @private
6161
*/
@@ -65,9 +65,8 @@ export interface EventExtensionTargets {
6565
/**
6666
* Fires when the cart is updated.
6767
*
68-
* @deprecated Deprecated as of `2026-04`. Use `shopify.cart.current.subscribe()` instead,
69-
* available on any render target. For background observation, use `pos.app.ready.data`
70-
* target with `shopify.addEventListener('cart_update', callback)`.
68+
* @deprecated Deprecated as of `2026-04`. Use `api.cart.current.subscribe()` on any
69+
* target instead. For background observation, use `pos.app.ready.data` target.
7170
* See https://shopify.dev/docs/api/pos-ui-extensions/unstable/targets/pos-app-ready-data
7271
* @private
7372
*/

0 commit comments

Comments
 (0)