feat: add loading api for admin app home#4441
Conversation
🚨🚨🚨 Docs migration in progress 🚨🚨🚨We are actively migrating UI extension reference docs to MDX in the
During this migration, please be aware of the following:
Doc comments in Examples that previously lived in this repo are being moved to the What should I do?
Thanks for your patience while we complete the migration! 🙏 |
873abb2 to
5a57bb0
Compare
|
/snapit |
|
🫰✨ Thanks @andrewiggins! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20260506151134",
"@shopify/ui-extensions-tester": "0.0.0-snapshot-20260506151134" |
MitchLillie
left a comment
There was a problem hiding this comment.
🎩 and types are looking good!
Background
Follow-up to https://github.com/shop/world/pull/653749, which exposes
shopify.loading(isLoading?: boolean)to hostedadmin.app.home.renderextensions.Similar to #4374, this updates the public admin app-home runtime types and tester mocks for the new API.
Related: shop/issues-admin-extensibility/issues/2457
Solution
LoadingApitype forshopify.loading(isLoading?: boolean).loadingonAppHomeApiforadmin.app.home.render.LoadingApifrom the admin API barrel.ui-extensions-testeradmin app-home mocks to includeshopify.loading().Validation
Use pnpm with
COREPACK_ENABLE_STRICT=0because this repo is configured foryarnandyarnis disabled on dev machines:COREPACK_ENABLE_STRICT=0 pnpm run buildCOREPACK_ENABLE_STRICT=0 pnpm run type-checkCOREPACK_ENABLE_STRICT=0 pnpm run test packages/ui-extensions-tester/COREPACK_ENABLE_STRICT=0 pnpm run lint