Session registration failure reasons.

eben-roux · eben-roux · commit e90fb4be480d · 2025-05-07T10:33:40.000+02:00
diff --git a/Shuttle.Access.AspNetCore/.package/package.nuspec b/Shuttle.Access.AspNetCore/.package/package.nuspec
@@ -3,7 +3,7 @@
 <package>
   <metadata>
     <id>Shuttle.Access.AspNetCore</id>
-    <version>7.2.2</version>
+    <version>7.2.3</version>
     <authors>Eben Roux</authors>
     <owners>Eben Roux</owners>
     <license type="expression">BSD-3-Clause</license>
@@ -17,7 +17,7 @@
     <tags>iam middleware authorization permissions</tags>
     <dependencies>
             <dependency id="Microsoft.IdentityModel.JsonWebTokens" version="8.7.0" />
-      <dependency id="Shuttle.Access" version="7.2.2" />
+      <dependency id="Shuttle.Access" version="7.2.3" />
       <dependency id="Shuttle.Core.Contract" version="20.0.1" />
     </dependencies>
   </metadata>
diff --git a/Shuttle.Access.AspNetCore/Properties/AssemblyInfo.cs b/Shuttle.Access.AspNetCore/Properties/AssemblyInfo.cs
@@ -9,10 +9,10 @@
 [assembly: AssemblyTitle(".NET Unified Platform")]
 #endif
 
-[assembly: AssemblyVersion("7.2.2.0")]
+[assembly: AssemblyVersion("7.2.3.0")]
 [assembly: AssemblyCopyright("Copyright (c) 2025, Eben Roux")]
 [assembly: AssemblyProduct("Shuttle.Access.AspNetCore")]
 [assembly: AssemblyCompany("Eben Roux")]
 [assembly: AssemblyConfiguration("Release")]
-[assembly: AssemblyInformationalVersion("7.2.2")]
+[assembly: AssemblyInformationalVersion("7.2.3")]
 [assembly: ComVisible(false)]
diff --git a/Shuttle.Access.AspNetCore/Shuttle.Access.AspNetCore.csproj b/Shuttle.Access.AspNetCore/Shuttle.Access.AspNetCore.csproj
@@ -13,7 +13,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" Version="8.7.0" />
-    <PackageReference Include="Shuttle.Access" Version="7.2.2" />
+    <PackageReference Include="Shuttle.Access" Version="7.2.3" />
     <PackageReference Include="Shuttle.Core.Contract" Version="20.0.1" />
   </ItemGroup>
 
diff --git a/Shuttle.Access.RestClient/.package/package.nuspec b/Shuttle.Access.RestClient/.package/package.nuspec
@@ -3,7 +3,7 @@
 <package>
   <metadata>
     <id>Shuttle.Access.RestClient</id>
-    <version>7.2.2</version>
+    <version>7.2.3</version>
     <authors>Eben Roux</authors>
     <owners>Eben Roux</owners>
     <license type="expression">BSD-3-Clause</license>
@@ -18,8 +18,8 @@
     <dependencies>
             <dependency id="Refit" version="8.0.0" />
       <dependency id="Refit.HttpClientFactory" version="8.0.0" />
-      <dependency id="Shuttle.Access" version="7.2.2" />
-      <dependency id="Shuttle.Access.AspNetCore" version="7.2.2" />
+      <dependency id="Shuttle.Access" version="7.2.3" />
+      <dependency id="Shuttle.Access.AspNetCore" version="7.2.3" />
       <dependency id="Shuttle.Core.Contract" version="20.0.1" />
     </dependencies>
   </metadata>
diff --git a/Shuttle.Access.RestClient/Properties/AssemblyInfo.cs b/Shuttle.Access.RestClient/Properties/AssemblyInfo.cs
@@ -9,10 +9,10 @@
 [assembly: AssemblyTitle(".NET Unified Platform")]
 #endif
 
-[assembly: AssemblyVersion("7.2.2.0")]
+[assembly: AssemblyVersion("7.2.3.0")]
 [assembly: AssemblyCopyright("Copyright (c) 2025, Eben Roux")]
 [assembly: AssemblyProduct("Shuttle.Access.RestClient")]
 [assembly: AssemblyCompany("Eben Roux")]
 [assembly: AssemblyConfiguration("Release")]
-[assembly: AssemblyInformationalVersion("7.2.2")]
+[assembly: AssemblyInformationalVersion("7.2.3")]
 [assembly: ComVisible(false)]
diff --git a/Shuttle.Access.RestClient/Shuttle.Access.RestClient.csproj b/Shuttle.Access.RestClient/Shuttle.Access.RestClient.csproj
@@ -13,8 +13,8 @@
   <ItemGroup>
 		<PackageReference Include="Refit" Version="8.0.0" />
 		<PackageReference Include="Refit.HttpClientFactory" Version="8.0.0" />
-		<PackageReference Include="Shuttle.Access" Version="7.2.2" />
-		<PackageReference Include="Shuttle.Access.AspNetCore" Version="7.2.2" />
+		<PackageReference Include="Shuttle.Access" Version="7.2.3" />
+		<PackageReference Include="Shuttle.Access.AspNetCore" Version="7.2.3" />
 		<PackageReference Include="Shuttle.Core.Contract" Version="20.0.1" />
 	</ItemGroup>
 
diff --git a/Shuttle.Access.WebApi/Endpoints/SessionEndpoints.cs b/Shuttle.Access.WebApi/Endpoints/SessionEndpoints.cs
@@ -60,7 +60,7 @@ public static WebApplication MapSessionEndpoints(this WebApplication app, ApiVer
             .MapToApiVersion(apiVersion1)
             .RequirePermission(AccessPermissions.Sessions.View);
 
-        app.MapPost("/v{version:apiVersion}/sessions", async (HttpContext httpContext, IOptions<AccessOptions> accessOptions, ISessionCache sessionCache, IMediator mediator, IDatabaseContextFactory databaseContextFactory, [FromBody] Messages.v1.RegisterSession message) =>
+        app.MapPost("/v{version:apiVersion}/sessions", async (ILogger<RegisterSession> logger, HttpContext httpContext, IOptions<AccessOptions> accessOptions, ISessionCache sessionCache, IMediator mediator, IDatabaseContextFactory databaseContextFactory, [FromBody] Messages.v1.RegisterSession message) =>
             {
                 var options = Guard.AgainstNull(accessOptions.Value);
 
@@ -71,7 +71,7 @@ public static WebApplication MapSessionEndpoints(this WebApplication app, ApiVer
 
                 if (string.IsNullOrWhiteSpace(message.IdentityName))
                 {
-                    return Results.BadRequest();
+                    return Results.BadRequest(Resources.SessionIdentityNameRequired);
                 }
                 
                 var registerSession = new RegisterSession(message.IdentityName);
@@ -92,9 +92,16 @@ public static WebApplication MapSessionEndpoints(this WebApplication app, ApiVer
                     {
                         var identityId = httpContext.GetIdentityId();
 
-                        if (!identityId.HasValue || !await sessionCache.HasPermissionAsync(identityId.Value, AccessPermissions.Sessions.Register))
+                        if (!identityId.HasValue)
                         {
-                            return Results.BadRequest();
+                            return Results.BadRequest(Resources.HttpContextIdentityNotFound);
+                        }
+
+                        if (!await sessionCache.HasPermissionAsync(identityId.Value, AccessPermissions.Sessions.Register))
+                        {
+                            logger.LogDebug($"[UNAUTHORIZED] : identity id = '{identityId.Value}' / permission = '{AccessPermissions.Sessions.Register}'");
+
+                            return Results.Unauthorized();
                         }
                     }
 
diff --git a/Shuttle.Access/.package/package.nuspec b/Shuttle.Access/.package/package.nuspec
@@ -3,7 +3,7 @@
 <package>
   <metadata>
     <id>Shuttle.Access</id>
-    <version>7.2.2</version>
+    <version>7.2.3</version>
     <authors>Eben Roux</authors>
     <owners>Eben Roux</owners>
     <license type="expression">BSD-3-Clause</license>
diff --git a/Shuttle.Access/Properties/AssemblyInfo.cs b/Shuttle.Access/Properties/AssemblyInfo.cs
@@ -9,10 +9,10 @@
 [assembly: AssemblyTitle(".NET Unified Platform")]
 #endif
 
-[assembly: AssemblyVersion("7.2.2.0")]
+[assembly: AssemblyVersion("7.2.3.0")]
 [assembly: AssemblyCopyright("Copyright (c) 2025, Eben Roux")]
 [assembly: AssemblyProduct("Shuttle.Access")]
 [assembly: AssemblyCompany("Eben Roux")]
 [assembly: AssemblyConfiguration("Release")]
-[assembly: AssemblyInformationalVersion("7.2.2")]
+[assembly: AssemblyInformationalVersion("7.2.3")]
 [assembly: ComVisible(false)]
diff --git a/Shuttle.Access/Resources.Designer.cs b/Shuttle.Access/Resources.Designer.cs
diff --git a/Shuttle.Access/Resources.resx b/Shuttle.Access/Resources.resx
@@ -138,6 +138,9 @@
     <value>Permission with Id '{0}' already exists on role '{1}'.</value>
     <comment>0 = permission, 1 = role name</comment>
   </data>
+  <data name="HttpContextIdentityNotFound" xml:space="preserve">
+    <value>Could not determine the identity from the HttpContext.</value>
+  </data>
   <data name="IdentityInactiveException" xml:space="preserve">
     <value>Identity with name '{0}' is inactive.</value>
     <comment>0 = identity name</comment>
@@ -178,6 +181,9 @@
     <value>Role '{0}' does not exist on user '{1}'.</value>
     <comment>0 = role name, 1 = user name</comment>
   </data>
+  <data name="SessionIdentityNameRequired" xml:space="preserve">
+    <value>`IdentityName` may not be empty.</value>
+  </data>
   <data name="SessionNotFound" xml:space="preserve">
     <value>Could not find a valid session.</value>
   </data>

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public static WebApplication MapSessionEndpoints(this WebApplication app, ApiVer`
`60`	`60`	`.MapToApiVersion(apiVersion1)`
`61`	`61`	`.RequirePermission(AccessPermissions.Sessions.View);`
`62`	`62`
`63`		`- app.MapPost("/v{version:apiVersion}/sessions", async (HttpContext httpContext, IOptions<AccessOptions> accessOptions, ISessionCache sessionCache, IMediator mediator, IDatabaseContextFactory databaseContextFactory, [FromBody] Messages.v1.RegisterSession message) =>`
	`63`	`+ app.MapPost("/v{version:apiVersion}/sessions", async (ILogger<RegisterSession> logger, HttpContext httpContext, IOptions<AccessOptions> accessOptions, ISessionCache sessionCache, IMediator mediator, IDatabaseContextFactory databaseContextFactory, [FromBody] Messages.v1.RegisterSession message) =>`
`64`	`64`	`{`
`65`	`65`	`var options = Guard.AgainstNull(accessOptions.Value);`
`66`	`66`
`@@ -71,7 +71,7 @@ public static WebApplication MapSessionEndpoints(this WebApplication app, ApiVer`
`71`	`71`
`72`	`72`	`if (string.IsNullOrWhiteSpace(message.IdentityName))`
`73`	`73`	`{`
`74`		`- return Results.BadRequest();`
	`74`	`+ return Results.BadRequest(Resources.SessionIdentityNameRequired);`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`var registerSession = new RegisterSession(message.IdentityName);`
`@@ -92,9 +92,16 @@ public static WebApplication MapSessionEndpoints(this WebApplication app, ApiVer`
`92`	`92`	`{`
`93`	`93`	`var identityId = httpContext.GetIdentityId();`
`94`	`94`
`95`		`- if (!identityId.HasValue \|\| !await sessionCache.HasPermissionAsync(identityId.Value, AccessPermissions.Sessions.Register))`
	`95`	`+ if (!identityId.HasValue)`
`96`	`96`	`{`
`97`		`- return Results.BadRequest();`
	`97`	`+ return Results.BadRequest(Resources.HttpContextIdentityNotFound);`
	`98`	`+ }`
	`99`	`+`
	`100`	`+ if (!await sessionCache.HasPermissionAsync(identityId.Value, AccessPermissions.Sessions.Register))`
	`101`	`+ {`
	`102`	`+ logger.LogDebug($"[UNAUTHORIZED] : identity id = '{identityId.Value}' / permission = '{AccessPermissions.Sessions.Register}'");`
	`103`	`+`
	`104`	`+ return Results.Unauthorized();`
`98`	`105`	`}`
`99`	`106`	`}`
`100`	`107`