- caching properties on DataRowMapper

Author: eben-roux

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2018, Eben Roux
+Copyright (c) 2019, Eben Roux
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification,

Shuttle.Core.Data.Tests/DefaultDbProviderFactories.cs

@@ -2,32 +2,41 @@
 using System.Collections.Generic;
 using System.Data;
 using System.Linq;
+using System.Reflection;
 using Shuttle.Core.Contract;
 
 namespace Shuttle.Core.Data
 {
     public class DataRowMapper : IDataRowMapper
     {
+        private readonly object _lock = new object();
+        private readonly Dictionary<Type, PropertyInfo[]> _properties = new Dictionary<Type, PropertyInfo[]>();
+
         public MappedRow<T> MapRow<T>(DataRow row) where T : new()
         {
             Guard.AgainstNull(row, nameof(row));
 
-            return new MappedRow<T>(row, Map<T>(row));
+            return new MappedRow<T>(row, Map<T>(GetPropertyInfo<T>(), row));
         }
 
         public IEnumerable<MappedRow<T>> MapRows<T>(IEnumerable<DataRow> rows) where T : new()
         {
-            return rows?.Select(row => new MappedRow<T>(row, Map<T>(row))).ToList() ?? new List<MappedRow<T>>();
+            var properties = GetPropertyInfo<T>();
+
+            return rows?.Select(row => new MappedRow<T>(row, Map<T>(properties, row))).ToList() ??
+                   new List<MappedRow<T>>();
         }
 
         public T MapObject<T>(DataRow row) where T : new()
         {
-            return Map<T>(row);
+            return Map<T>(GetPropertyInfo<T>(), row);
         }
 
         public IEnumerable<T> MapObjects<T>(IEnumerable<DataRow> rows) where T : new()
         {
-            return rows?.Select(Map<T>).ToList() ?? new List<T>();
+            var properties = GetPropertyInfo<T>();
+
+            return rows?.Select(row => Map<T>(properties, row)).ToList() ?? new List<T>();
         }
 
         public T MapValue<T>(DataRow row)
@@ -40,17 +49,31 @@ public IEnumerable<T> MapValues<T>(IEnumerable<DataRow> rows)
             return rows?.Select(MapRowValue<T>).ToList() ?? new List<T>();
         }
 
-        private T Map<T>(DataRow row) where T : new()
+        private PropertyInfo[] GetPropertyInfo<T>()
+        {
+            lock (_lock)
+            {
+                var type = typeof(T);
+
+                if (!_properties.ContainsKey(type))
+                {
+                    _properties.Add(type, type.GetProperties());
+                }
+
+                return _properties[type];
+            }
+        }
+
+        private T Map<T>(PropertyInfo[] properties, DataRow row) where T : new()
         {
             if (row == null)
             {
                 return default(T);
             }
 
             var result = new T();
-            var type = typeof(T);
 
-            foreach (var pi in type.GetProperties())
+            foreach (var pi in properties)
             {
                 try
                 {
@@ -78,7 +101,7 @@ private static T MapRowValue<T>(DataRow row)
 
             return row?[0] == null
                 ? default(T)
-                : (T)Convert.ChangeType(row[0], underlyingSystemType);
+                : (T) Convert.ChangeType(row[0], underlyingSystemType);
         }
     }
 }

Shuttle.Core.Data/DataRowMapper.cs

@@ -13,10 +13,10 @@
 [assembly: AssemblyTitle(".NET Standard 2.0")]
 #endif
 
-[assembly: AssemblyVersion("11.0.2.0")]
+[assembly: AssemblyVersion("11.0.3.0")]
 [assembly: AssemblyCopyright("Copyright © Eben Roux 2019")]
 [assembly: AssemblyProduct("Shuttle.Core.Data")]
 [assembly: AssemblyCompany("Shuttle")]
 [assembly: AssemblyConfiguration("Release")]
-[assembly: AssemblyInformationalVersion("11.0.2")]
+[assembly: AssemblyInformationalVersion("11.0.3")]
 [assembly: ComVisible(false)]