Merge pull request #427 from SiaFoundation/chris/wrap-client-error

Wrap client errors

Author: n8mgr

.changeset/wrap_client_rpc_errors_in_rpcerror.md

@@ -0,0 +1,5 @@
+---
+default: patch
+---
+
+# Wrap client rpc errors in RPCError.

rhp/v4/client_test.go

@@ -0,0 +1,26 @@
+package rhp
+
+import (
+	"errors"
+	"testing"
+
+	rhp4 "go.sia.tech/core/rhp/v4"
+)
+
+func TestClientErrWrapping(t *testing.T) {
+	sentinel := errors.New("sentinel")
+
+	// clientErr joins an outer ClientError with the inner error.
+	err := clientErr("desc", sentinel)
+	if code := rhp4.ErrorCode(err); code != rhp4.ErrorCodeClientError {
+		t.Fatalf("expected ClientError, got %d", code)
+	} else if !errors.Is(err, sentinel) {
+		t.Fatal("expected inner sentinel to be in the chain")
+	}
+
+	// clientErrf produces a standalone ClientError without an inner.
+	err = clientErrf("desc %d", 1)
+	if code := rhp4.ErrorCode(err); code != rhp4.ErrorCodeClientError {
+		t.Fatalf("expected ClientError, got %d", code)
+	}
+}