Fix pool index#425
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
Fixes an indexing bug in the transaction pool where newly-added v2 transactions were recorded with the wrong index, which could lead to incorrect lookups (and potentially panics/out-of-bounds access) when retrieving v2 pool transactions by ID.
Changes:
- Correct v2 txpool index assignment to use the v2 transaction slice length when inserting new v2 transactions.
- Add a changeset documenting the patch-level fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
chain/manager.go |
Fixes the index stored in txpool.indices when adding v2 pool transactions so it matches the v2txns slice. |
.changeset/fix_incorrect_v2_pool_index.md |
Documents the fix as a patch change for release notes/changelog generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.