Skip to content

Fix pool index#425

Merged
lukechampine merged 1 commit into
masterfrom
nate/v2-pool-index
May 5, 2026
Merged

Fix pool index#425
lukechampine merged 1 commit into
masterfrom
nate/v2-pool-index

Conversation

@n8mgr
Copy link
Copy Markdown
Member

@n8mgr n8mgr commented May 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 5, 2026 18:40
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an indexing bug in the transaction pool where newly-added v2 transactions were recorded with the wrong index, which could lead to incorrect lookups (and potentially panics/out-of-bounds access) when retrieving v2 pool transactions by ID.

Changes:

  • Correct v2 txpool index assignment to use the v2 transaction slice length when inserting new v2 transactions.
  • Add a changeset documenting the patch-level fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
chain/manager.go Fixes the index stored in txpool.indices when adding v2 pool transactions so it matches the v2txns slice.
.changeset/fix_incorrect_v2_pool_index.md Documents the fix as a patch change for release notes/changelog generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread chain/manager.go
@lukechampine lukechampine merged commit ff5f457 into master May 5, 2026
18 checks passed
@lukechampine lukechampine deleted the nate/v2-pool-index branch May 5, 2026 20:38
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sia May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants