Skip to content

Commit 96e754b

Browse files
committed
Merge branch 'main' of github.com:Sideko-Inc/sideko
2 parents 2193c67 + d0306cf commit 96e754b

7 files changed

Lines changed: 15 additions & 10 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ on:
4747
jobs:
4848
# Run 'dist plan' (or host) to determine what tasks we need to do
4949
plan:
50-
runs-on: "ubuntu-20.04"
50+
runs-on: "ubuntu-22.04"
5151
outputs:
5252
val: ${{ steps.plan.outputs.manifest }}
5353
tag: ${{ !github.event.pull_request && github.ref_name || '' }}
@@ -168,7 +168,7 @@ jobs:
168168
needs:
169169
- plan
170170
- build-local-artifacts
171-
runs-on: "ubuntu-20.04"
171+
runs-on: "ubuntu-22.04"
172172
env:
173173
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
174174
BUILD_MANIFEST_NAME: target/distrib/global-dist-manifest.json
@@ -218,7 +218,7 @@ jobs:
218218
if: ${{ always() && needs.plan.outputs.publishing == 'true' && (needs.build-global-artifacts.result == 'skipped' || needs.build-global-artifacts.result == 'success') && (needs.build-local-artifacts.result == 'skipped' || needs.build-local-artifacts.result == 'success') }}
219219
env:
220220
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
221-
runs-on: "ubuntu-20.04"
221+
runs-on: "ubuntu-22.04"
222222
outputs:
223223
val: ${{ steps.host.outputs.manifest }}
224224
steps:
@@ -278,7 +278,7 @@ jobs:
278278
needs:
279279
- plan
280280
- host
281-
runs-on: "ubuntu-20.04"
281+
runs-on: "ubuntu-22.04"
282282
env:
283283
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
284284
PLAN: ${{ needs.plan.outputs.val }}
@@ -323,7 +323,7 @@ jobs:
323323
needs:
324324
- plan
325325
- host
326-
runs-on: "ubuntu-20.04"
326+
runs-on: "ubuntu-22.04"
327327
env:
328328
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
329329
PLAN: ${{ needs.plan.outputs.val }}
@@ -357,7 +357,7 @@ jobs:
357357
# still allowing individual publish jobs to skip themselves (for prereleases).
358358
# "host" however must run to completion, no skipping allowed!
359359
if: ${{ always() && needs.host.result == 'success' && (needs.publish-homebrew-formula.result == 'skipped' || needs.publish-homebrew-formula.result == 'success') && (needs.publish-npm.result == 'skipped' || needs.publish-npm.result == 'success') }}
360-
runs-on: "ubuntu-20.04"
360+
runs-on: "ubuntu-22.04"
361361
env:
362362
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
363363
steps:

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ curl -fsSL https://raw.githubusercontent.com/Sideko-Inc/sideko/main/install.sh |
3939

4040
## Quickstart - Premium SDKs in Seconds
4141
```bash
42-
# authenticate
42+
# authenticate (uses native keychain to store credentials on host)
4343
sideko login
4444

4545
# interactively create sdks

dist-workspace.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,6 @@ tap = "Sideko-Inc/homebrew-tap"
2626
publish-jobs = ["homebrew", "npm"]
2727
# A namespace to use when publishing this package to the npm registry
2828
npm-scope = "@sideko"
29+
30+
[dist.github-custom-runners]
31+
global = "ubuntu-22.04"

sideko-py/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22
name = "sideko-py"
33
description = "Generate & manage SDKs with the Sideko CLI"
4-
version = "1.1.1"
4+
version = "1.1.3"
55
edition = "2021"
66
authors = [
77
"Elias Posen <elias@sideko.dev>",

sideko/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "sideko"
3-
version = "1.1.1"
3+
version = "1.1.3"
44
edition = "2021"
55
authors = [
66
"Elias Posen <elias@sideko.dev>",

sideko/src/cmds/login.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ pub(crate) struct LoginCommand {
2323

2424
impl LoginCommand {
2525
pub async fn handle(&self) -> CliResult<()> {
26+
info!("🔑🔑🔑 this CLI uses your OS keychain to securely store your Sideko API key...");
2627
if let Some(key) = &self.key {
2728
utils::config::ConfigKey::ApiKey.set_keyring(key)?;
2829
info!("{} CLI authenticated", fmt_green("✔"));
@@ -48,6 +49,7 @@ impl LoginCommand {
4849
.map_err(|e| CliError::general_debug("Failed building login URL", format!("{e:?}")))?;
4950

5051
info!("continue by logging in with the browser popup...");
52+
5153
if let Err(e) = open::that(login_url.as_str()) {
5254
log::warn!(
5355
"failed opening browser for login, please navigate to `{login_url}` to complete login"

0 commit comments

Comments
 (0)