A vectorized approach to coord conversion. Provides a significant speed up.#44
Open
mathiser wants to merge 1 commit into
Open
A vectorized approach to coord conversion. Provides a significant speed up.#44mathiser wants to merge 1 commit into
mathiser wants to merge 1 commit into
Conversation
Owner
|
Hi @mathiser I have tried to run your vectorized solution and I am running into two issues:
Especially the last issue seems problematic. It shows that the resulting masks in the nii files have no overlap with the expected masks. Upon manual inspection this seems to be because the mask is empty. Is it possible for you to have a look at this issue? |
Author
|
Yirks, sorry about that. I'll review it ASAP... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Sikerdebaard
Another PR with vectorized approach. A little tweaked compared to the other PR I closed yesterday. It provides a significant speed up by approximately 50 % (1 min 3 sec vs 28 sec in my test)
It does two things:
Mathis