Skip to content

Code size reduction in SLC components#520

Merged
Jean-Francois Penven (jepenven-silabs) merged 3 commits intorelease_2.9-1.6from
matter_5920_code_size_reduction
May 6, 2026
Merged

Code size reduction in SLC components#520
Jean-Francois Penven (jepenven-silabs) merged 3 commits intorelease_2.9-1.6from
matter_5920_code_size_reduction

Conversation

@jepenven-silabs
Copy link
Copy Markdown
Contributor

@jepenven-silabs Jean-Francois Penven (jepenven-silabs) commented Mar 10, 2026

Issue Link:
MATTER-5921

Description of Problem/Feature:
SLC builds are usually bigger than the GN ones. This PR is an attempt at closing that gap by making optionnal and the ReadClient feature (only needed when the sample apps reads something on another node) and other optionnal feature.

Description of Fix/Solution:
Removes optionnal features from the default offering

Testing Done:
Samples builded and were commissionnable.

sarthak shaha (Sarthak-Shaha) pushed a commit to Sarthak-Shaha/matter_extension that referenced this pull request Mar 20, 2026
…ations Improvement

Merge in WMN_TOOLS/matter_extension from improvement/icd_server_config_component to release_2.6-1.4

Squashed commit of the following:

commit e9bb74d51d04690f309c88076acc7fd43afc38a5
Author: ardutta <arghya.dutta@silabs.com>
Date:   Fri Jul 4 13:58:29 2025 +0530

    Added Capitalization  in the ICD Server Configuration UI

commit be2ed0ad61e165114112e5817a936289660aafcf
Author: ardutta <arghya.dutta@silabs.com>
Date:   Fri Jul 4 10:13:44 2025 +0530

    Updated the ICD Server Configuration

commit 246b2269f670c07f3a54b0c051d5bf7c7c8c77c7
Author: Arghya Dutta <arghya.dutta@silabs.com>
Date:   Thu Jul 3 11:39:43 2025 +0530

    Added units in the ICD Server Configuration UI

commit 810abaecbcb96701e0d8427b83bd378fe4591c65
Author: Arghya Dutta <arghya.dutta@silabs.com>
Date:   Wed Jul 2 13:26:50 2025 +0530

    Updated the ICD Server Configuration
@jepenven-silabs Jean-Francois Penven (jepenven-silabs) changed the base branch from main to release_2.9-1.6 April 23, 2026 23:31
Copilot AI review requested due to automatic review settings April 24, 2026 00:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce default SLC build size by disabling optional Matter features (notably the Interaction Model Read Client) unless explicitly enabled via components.

Changes:

  • Disable CHIP_CONFIG_ENABLE_READ_CLIENT by default in the SLC app build config.
  • Introduce a new matter_read_client SLC component that re-enables the read client and adds its sources/headers.
  • Adjust related SLC components (shell, interaction model/datamodel packaging, OTA requestor includes, no-debug size-reduction defines) to align with the new optional split.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
slc/inc/app/AppBuildConfig.h Changes default read-client enablement to reduce baseline footprint.
slc/component/matter-platform/size-reduction/matter_no_debug.slcc Disables CLI arg parser when shell isn’t present to save size.
slc/component/matter-platform/shell/matter_shell.slcc Gates IM shell command sources behind the new read-client option.
slc/component/matter-core-sdk/read_client.slcc Adds a new optional component encapsulating ReadClient sources/define.
slc/component/matter-core-sdk/libchipdatamodel.slcc Removes read-client-related headers/sources from the default datamodel packaging.
slc/component/matter-core-sdk/interaction_model.slcc Removes ReadClient.cpp from default build, keeps header available for compilation.
slc/component/matter-clusters/matter_ota_requestor.slcc Updates include dependencies to account for read-client headers no longer being default.

Comment thread slc/inc/app/AppBuildConfig.h Outdated
Comment thread slc/component/matter-core-sdk/read_client.slcc Outdated
Comment thread slc/component/matter-core-sdk/read_client.slcc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.
Current copilot comments should be applied

@jepenven-silabs Jean-Francois Penven (jepenven-silabs) merged commit 053a7a0 into release_2.9-1.6 May 6, 2026
212 checks passed
@jepenven-silabs Jean-Francois Penven (jepenven-silabs) deleted the matter_5920_code_size_reduction branch May 6, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants