PLATFORM_MTL-12127: Fix sl_setup_env.py and build.sh for Git Bash on Windows#648
Draft
Cedric Migliorini (migligli) wants to merge 1 commit intoSiliconLabsSoftware:mainfrom
Conversation
…Windows sl_setup_env.py: - Resolve SLT CLI from SILABS_SLT/SLT_EXE env, then PATH, before falling back to bundled slc/tools/slt. Skip download and slt update --self when using an external SLT. - Add --use-bundled-slt flag to force the old behavior. - Pass stdin=subprocess.DEVNULL to slt subprocess calls to prevent interactive prompts from hanging non-interactive runs. - Single-quote all .env values on Windows so that semicolons in TOOLS_PATH, backslashes, and spaces (e.g. Simplicity Commander) are safe when build.sh sources the file in bash. build.sh: - Convert Windows TOOLS_PATH (semicolon-separated) to Unix PATH via cygpath -p -u when running under Git Bash / MSYS. - Force OS=Windows_NT and pass OS, ARM_GCC_DIR, POST_BUILD_EXE, and USERPROFILE on the make command line so generated Makefiles select the correct Windows toolchain paths in recursive builds. - Resolve POST_BUILD_EXE to a full path when .env provides only a basename (e.g. commander.exe). - Accept slc.bat in addition to slc for the SLC CLI check. - Fail early with a clear message when GNU Make is not on PATH.
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: example@example.com or I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: example@example.com Signature is valid for 6 months. This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
https://jira.silabs.com/browse/PLATFORM_MTL-12127
Description of Problem/Feature:
See this MD file OUT_PLATFORM_MTL-12127_Description-changes-to-scripts.md
Description of Fix/Solution:
See this MD file OUT_PLATFORM_MTL-12127_Description-changes-to-scripts.md
Testing Done:
I was able to run the following scripts on my Windows 11 OS machine from a git bash terminal:
Details from the commit message:
sl_setup_env.py:
build.sh: