MATTER-5224: Implement automated generation of metadata with hwfilter#670
Open
Michael Duggan (miduggan24) wants to merge 6 commits intomainfrom
Open
MATTER-5224: Implement automated generation of metadata with hwfilter#670Michael Duggan (miduggan24) wants to merge 6 commits intomainfrom
Michael Duggan (miduggan24) wants to merge 6 commits intomainfrom
Conversation
d7a304c to
8ba2a1b
Compare
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 384c32b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
MATTER-5224
Description of Problem/Feature:
Need standardized way to generate all metadata files
Description of Fix/Solution:
Implement the following to automatically generate
matter_templates.xml,matter_demos.xml, and newboard_compatibility_matrix.htmlto help with manual work of updating confluence with matrixgenerate_metadata_hwfilter.pyscript to generate metadata files by cloning hwfilter locally and running with latest sisdk and wiseconnect packages to pick up boards and deviceshwfilter-config.ymlas high-level board and device filtering for hwfilter to apply to all appsmetadata-generation.ymlto handle demo variants built in CI, exclusions from templates and demos files, hard-coded board lists for special cases, and using boards from CI for demos for certain appsTesting Done:
Note
Medium Risk
Medium risk because it changes CI validation and adjusts TrustZone build arguments, which could cause builds or metadata checks to start failing if expectations differ. The large generated
board_compatibility_matrix.htmlis low functional risk but adds repository noise/size.Overview
Metadata validation is expanded in CI and TrustZone build args are simplified.
The MG24 TrustZone CI config drops
--output_suffix trustzonefrom.github/silabs-builds-mg24-trustzone.json, relying on naming/other mechanisms for TrustZone identification.The
validate-metadataGitHub Actions workflow adds a newvalidate-demo-imagesjob that runsslc/script/validate_demo_images.pyto ensurematter_demos.xmldemo image URIs map to existing.slcwsolutions and are covered by the appropriate CI board JSONs.A generated
board_compatibility_matrix.htmlis added to the repo, providing an example-vs-board compatibility matrix for reference/documentation.Reviewed by Cursor Bugbot for commit d4da968. Bugbot is set up for automated code reviews on this repo. Configure here.