Sync csa branch with main#871
Merged
Merged
Conversation
* Update Silabs Docker * address comments geminit * address comments gemini * Restyled by autopep8 * matter_support bump:main * matter_support bump:main:revert --------- Co-authored-by: Restyled.io <commits@restyled.io>
* adding session close on all crypto operations * session close error logs
* fix docker workflow * version * version file update * Update scripts/setup/silabs/install-packages.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…#43356) * Rename all GCAST test and pics to GC per testplan/spec. Fix some of the GC test script when the DUT as Sender feature only * Fix TC_GC_2_3 stepup condition * Restyled by isort --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Improve thread logs for faults and connection change * clena up logs * rename test * Restyled by clang-format * add maybe unused * fix copilot suggestion * Simplify ThreadNetworkDiagnosticsCluster log message Avoid formatting `size_t` to resolve build failures on some platforms where it requires different format specifiers (`%lu` vs `%u`). * Address review comments on PR #43317 - Modifies `GetPanId()` in `ThreadNetworkDiagnosticsProvider` to return `0xffff` (an invalid PAN ID) instead of fake `0` when no dataset is present. - Abstraction fully shields the cluster codebase from `otInstance` and other internal OpenThread datatypes, removing the need for new includes. - Addresses doc comments feedback by placing the documentation in `ThreadNetworkDiagnosticsProvider.h`. - Updates `ThreadNetworkDiagnosticsCluster` to unconditionally log the returned PAN ID since invalid cases will print `0xffff`, keeping formatting simple. * Restyled by clang-format * Shorten log strings in ThreadNetworkDiagnosticsCluster to save flash space --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Draft for Color Control 6.5 * Endpoint updated, added steps expected data, restart updated. * Variable rename, ruff check. * Added missing expire session * Code review fix * Removed yaml test for CC 6.5 * Fixed asserts for int values with matter_asserts. Fixed null value check. * Removed read of send_single_cmd response * Address review comments in TC_CC_6_5 * Restyled * Fix syntax errors and indentation * Fixed imports and PICS * Restyled by ruff * Restyled by isort * fixed missing decorator * Fixed an erroneous decorator statement * Restyled * Updated code to use self.request_device_reboot() to PowerOff and PowerOn the device * Restyled by ruff * Removed invalid Null check for StartUpColorTemperatureMireds * Added ready patter for app * test: check if this solve the CI issue * Revert "test: check if this solve the CI issue" This reverts commit 75548daa3845d5414fafc7337aeb6cdd806a7db0. * Added small await to remove connection * Updated wait time to let the app to shutdown/start * ci test * Restore wait * Remove await sleep --------- Co-authored-by: Fran <franluntref@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Ramiro Recchia <rrecchia@google.com> Co-authored-by: Franco Lionti <43421214+FrancoLionti@users.noreply.github.com> Co-authored-by: Andrey Khodyrev <khodyrev@google.com>
…k link is up (#43361) * Fix kLinkDown fault not removed when thread network link is up This commit fixes an issue where the `kLinkDown` fault in `GenericThreadStackManagerImpl_OpenThread::_OnPlatformEvent` was correctly added when the thread connection state detached, but wasn't removed when the thread connection state reattached (i.e. `mIsAttached == true`). To support this cleanly, `remove(const uint8_t value)` has been added to the `GeneralFaults` utility to allow targeted removals of particular faults. Testing: - Added `TestGeneralFaults` unit tests in `src/platform/tests` - Verified the fix builds across linux-x64 host tests. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
silabs-matter-ci-bot
Bot
added
sl-require-admin-action
Contributor
|
The check for |
…3355) * Groupcast: Bugfix: Added missing validation of MaxMcastAddrCount. * Code review.
… a Sender only (#43362) * Fix a issue where replaceEndpoints field was alloew for a Sender only * Update src/app/clusters/groupcast/GroupcastLogic.cpp Co-authored-by: Sergio Soares <sergiosoares@google.com> * Restyled by clang-format --------- Co-authored-by: Sergio Soares <sergiosoares@google.com> Co-authored-by: Restyled.io <commits@restyled.io>
sarthak shaha (Sarthak-Shaha)
approved these changes
Mar 1, 2026
* Make ASSERT_{TRUE,FALSE} clang-tidy friendly
... by not "hiding" the test outcome inside a lambda.
Also add a GetStatusCode helper to ClusterTester so the status can be directly
compared as a std::optional without a separate has_value() check.
* Remove NOLINT bugprone-unchecked-optional-access from tests
- ASSERT_TRUE(has_value()) is now understood to guard the dereference
- Where possible compare optionals directly without dereferencing,
so the separate ASSERT_TRUE isn't needed at all.
- Use the GetStatusCode() helper where possible.
- TestGroupsCluster: Introduce a ResponseStatus helper so the status
code contained in the response can be directly compared as an optional.
* restyle
* Make things work with googletest as well
* restyle
…example (#43336) * [config][common] Add CHIP_ENABLE_ACL_EXTENSIONS config Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp toup][platform][nxp][common] Define CHIP_CONFIG_ENABLE_ACL_EXTENSIONS to the config Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][examples][lock-app] Enable AccessControl's Extension attribute in lock-app * Feature is mandatory for lock-app and must be enabled in featuremap. Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [nxp][platform][common] Set CHIP_CONFIG_ENABLE_ACL_EXTENSIONS to 1 * Set CHIP_CONFIG_ENABLE_ACL_EXTENSIONS to 1 if CONFIG_CHIP_ENABLE_ACL_EXTENSIONS Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
…e (#43334) * [nxp][src][platform][common] Allow KeyValueStoreManagerImpl::_Get to check key existence * Allow KeyValueStoreManagerImpl::_Get to be passed a null buffer with zero size to enable the function to check the existence of the key without retrieving the value. * This is needed for some matter stack functions such as GenericThreadDriver::BackupExists Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * [examples][persistent-storage][kvs] Add TestKeyExistence to KeyValueStorageTest * This test adds check for key existence that is assumed by some function from matter sdk (e.g. GenericThreadDriver::BackupExists()) Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> * Restyled by clang-format --------- Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io>
…ster's EFS value (#43371)
* include lwip * add paths to efr32
* [nrfconnect] Optimize NVM usage for nRF52840dk This commit reduces NVM memory for nRF52840dk by enabling LTO. Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> * Revert "Use error logs only for NRF all-clusters (#43358)" This reverts commit ff99f98. --------- Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Bumps [third_party/nanopb/repo](https://github.com/nanopb/nanopb) from `671672b` to `98bf4db`. - [Release notes](https://github.com/nanopb/nanopb/releases) - [Commits](nanopb/nanopb@671672b...98bf4db) --- updated-dependencies: - dependency-name: third_party/nanopb/repo dependency-version: 98bf4db69897b53434f3d0ba72e0a3ab1a902824 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…376) Bumps [third_party/libdatachannel/repo](https://github.com/paullouisageneau/libdatachannel) from `28b2e73` to `a33ffc1`. - [Release notes](https://github.com/paullouisageneau/libdatachannel/releases) - [Commits](paullouisageneau/libdatachannel@28b2e73...a33ffc1) --- updated-dependencies: - dependency-name: third_party/libdatachannel/repo dependency-version: a33ffc1aeaab38b29764f6f9fa53b776b99cfeb4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [Tizen] Fix platform version parsing for Tizen >= 10.0 * Check for correct version parsing
* [nxp][common] Enable PowerDown for ICDs during Idle Mode An ICDObserver is used to manage the low power states according to the modes of the ICD (Active or Idle). In this context, the crypto engine is switched off during PowerDown and therefore all its context is lost, including the keystore, and some adjustments are necessary to avoid data loss. Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [nxp][cmake] Add NXP_USE_POWER_DOWN build option Added the NXP_USE_POWER_DOWN build option which will enable PowerDown as a low power state on the platforms that support it. Signed-off-by: Marian Chereji <marian.chereji@nxp.com> --------- Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
* Add laundry dryer controls delegate * Include files in build * compile fix * compile debug * Add test for laundry dryer app * Clusters and initialisations for laundry dryer * Init laundry dryer controls * test debug * test debug * test debug * identify tests * laundry washer mode * Rename tests * Temperature controls cluster * Fix test bug * Fix test bug * Restyled by clang-format * Restyled by ruff * Restyled by autopep8 * fix lints * Fix error * Add static guards to allow initializers to be called only once --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Refactor interface creation for Linux namespaces Changed so that there is clear relationship between up and down commands, with more granular registering of executed commands, allowing for partial cleanup without errors. Also, added an explicit XMLRPC server interface, which will be later used for XMLRPC server namespace encapsulation. Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * tests/linux: Remove confusing SubprocessKind.RPC Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * tests/linux: Fix network link up method signature Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * tests/linux: Enable IPv6 for all interfaces Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * tests/linux: Fix KeyError usage to ValueError Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * tests/linux: Fix netns constructor parameter order and type hints Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Don't use properties for setup/link_up_cmds Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Don't pass index as link argument Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Rename tool to ctrl and rpc to mgmt Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Refactor the new network resource abstraction Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Restore accidentally removed SubprocessKind.RPC (and rename it to MGMT to be in line with the new naming) Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix small docstring lint Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix comment lint Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix IPv6 for app and ctrl links Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix ns command wrapper for thread router Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix wait_for_dad for namespaces Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix wait for dad Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fallback to namespaceless execution in an unlikely corner case Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Make run_test_suite.py work again, some places were missing --tool-path -> --ctrl-path conversion Signed-off-by: Maciej Grela <m.grela@samsung.com> * General improvements on the Linux namespace handling to make it simpler to understand and extend: - allow for multiple ipv4 / ipv6 addresses to be specified simplifying IPv6 link-local/ULA handling - dropping the need for _cmd_history by using dependency information to teardown the isolated namespace(s) object graph - separating out register_dependencies into multiple methods to avoid type matches Signed-off-by: Maciej Grela <m.grela@samsung.com> * Fix ruff errors Signed-off-by: Maciej Grela <m.grela@samsung.com> * Set accept_ra to work when forwarding is enabled. * Move network namespace code to matter_testing_infrastructure Signed-off-by: Maciej Grela <m.grela@samsung.com> * Remove unused import Signed-off-by: Maciej Grela <m.grela@samsung.com> * Convert to new IsolatedNetworkNamespace API Signed-off-by: Maciej Grela <m.grela@samsung.com> * Rework state flag checks Signed-off-by: Maciej Grela <m.grela@samsung.com> * Properly handle check=False in WrappableCmd.run Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restore SubprocessKind.TOOL and related code (like commandline flags) Signed-off-by: Maciej Grela <enki@fsck.pl> * Implement post-review suggestions, in particular: - make networking object ownership explicit, do explicit setup/teardown and drop network resource dependency mechanism - moved "run in namespace" logic from WrappedCmd to NetworkResource as the namespace is attached there Signed-off-by: Maciej Grela <m.grela@samsung.com> * Use IsolatedNetworkNamespace abstractions to build otbr-agent commands Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by autopep8 * Restyled by isort * Implement review suggestions, fix wrong import. Signed-off-by: Maciej Grela <m.grela@samsung.com> * Move SubprocessKind and SubprocessInfo to matter_testing_infrastructure Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by ruff * Import all symbols used by chiptest.runner's downstream Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by isort * Silence ruff check because we need to import these for downstream users Signed-off-by: Maciej Grela <m.grela@samsung.com> * Don't use python_path to allow scripts to be run outside of venv (looking at you matter_yaml_linter.py) Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by isort * Use the `matter.testing.tasks` module instead of `matter.testing.subprocess` not not alias the system `subprocess` module Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by isort * More import conversions Signed-off-by: Maciej Grela <m.grela@samsung.com> * Implement post-review changes: - install basic python deps in cert_test_checks.yaml - use python_path everywhere - `netns_cmd_wrapper` and `wrap_cmd` now work with list[str] first and foremost with str as fallback - add documentation for NetworkResource - consolidate up_cmds for ipv6 Signed-off-by: Maciej Grela <m.grela@samsung.com> * Clean up imports Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by isort * Harmonize NetworkLink to use .name like other resource types Signed-off-by: Maciej Grela <m.grela@samsung.com> * Spelling mistake Signed-off-by: Maciej Grela <m.grela@samsung.com> * Include system pkgs for matter_yaml_linter.py venv Signed-off-by: Maciej Grela <m.grela@samsung.com> * Format exception message properly Signed-off-by: Maciej Grela <m.grela@samsung.com> * Simplify state tracking Signed-off-by: Maciej Grela <m.grela@samsung.com> * Promote .name to a property of NetworkResource, properly attach docstrings to fields Signed-off-by: Maciej Grela <m.grela@samsung.com> * Don't bring up lo if we aren't in a netns, always import matter.testing.tasks using the same package path Signed-off-by: Maciej Grela <m.grela@samsung.com> * Restyled by autopep8 * Restyled by isort * Implement review changes: - always use `with PythonPath` when importing matter_testing_infrastructure - change up_flag after all up/down commands have been successfull Signed-off-by: Maciej Grela <m.grela@samsung.com> --------- Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> Signed-off-by: Maciej Grela <m.grela@samsung.com> Signed-off-by: Maciej Grela <enki@fsck.pl> Co-authored-by: Maciej Grela <m.grela@samsung.com> Co-authored-by: Maciej Grela <enki@fsck.pl> Co-authored-by: Restyled.io <commits@restyled.io>
… (#43396) * [NXP][SE05x] Moving SE05x management in a dedicated application files Improving NXP app architecture to better isolate SE05x app in custom files. Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> * Addressing PR comment Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com> --------- Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
* Refactor duplicate tag handling in TC_DeviceBasicComposition The original logic was just comparing tag IDs which fails as soon as tags from multiple namespaces are used and the tag ids overlap by chance. This patch fixes this. (Done with AI support and verified locally) * Update src/python_testing/TC_DeviceBasicComposition.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ns. (#42964) * [BooleanStateConfiguration] Add per-attribute change callback functions. * Apply suggested changes. * Restyled by clang-format * Apply copilot suggestions * Restyled by clang-format * Return boolean on attribute change callback, seprate change callback and notify attribute changed. * Restyled by whitespace * Restyled by clang-format * Apply code suggestions --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Move only files * Fix doxygen comments
…(#43319) * extend NotifySendCheckIn for all check-in node * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Fix OT default info prints * apply comments * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
… to code-driven implementation (#43338) * Switch basic information implementation. * Update examples/bridge-app/linux/include/Device.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update examples/bridge-app/linux/Device.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Restyle * Update examples/bridge-app/linux/Device.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update based on code review comments - some cleanup. * Start cleaning up some device members. It looks like I will need to support location in the bridge device information cluster. * Bring back location - it is NOT the location for the device (that is disallowed in bridge) but it is endpoint info * A return fix * More code review updates * Update examples/bridge-app/linux/include/Device.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update examples/bridge-app/linux/Device.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add device cleanup code * Fix typo * Better unregister logic, so same device can be reused * Update examples/bridge-app/linux/include/Device.h * Update examples/bridge-app/linux/include/Device.h * Fix compile --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…(#43392) * install dload pip package in build examples script for CI * install packages from requirements file
* Update triage with latest known available maintainers * Update docs/issue_triage.md * Restyle
…lbacks (#43393) * Linux/Dnssd: StopResolve now synchronously delivers CHIP_ERROR_CANCELLED to matching pending resolve callbacks and removes their contexts to avoid later callbacks firing on stale/unused work. * Removing the entry from mAllocatedResolves first (capture the pointer, erase it, then invoke the callback and finally Delete) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactored to detach contexts from mAllocatedResolves before invoking the cancelled callbacks and deleting. * simplified list removal with remove_if --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Junior Martinez (jmartinez-silabs)
approved these changes
Mar 3, 2026
silabs-matter-ci-bot
Bot
force-pushed
the
automation/update_main
branch
from
9a3d9b7 to
59ff146
Compare
* Start supporting the device location attribute * Make device location optional * Make configuration version optional * Update comments on persistence * Some const correctness and restyle * Fix with latest API updates * Restyle * Update for empty charspan * Fix compile * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * More validation on TLV loads * Update comment * fix tests * Replace operator== with a named method * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.h Co-authored-by: Sergio Soares <sergiosoares@google.com> * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.h Co-authored-by: Sergio Soares <sergiosoares@google.com> * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.cpp Co-authored-by: Sergio Soares <sergiosoares@google.com> * Update examples/bridge-app/linux/Device.cpp Co-authored-by: Sergio Soares <sergiosoares@google.com> * Restyle and some light comment update * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/app/persistence/AttributePersistence.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Restyle and some light comment update * Remove the stack-based load convenience: it is a footgun! --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Sergio Soares <sergiosoares@google.com>
…foreground (#43127)" (#43416) This reverts commit ead8174.
* matter_support update and integrations fixes * Restyled by clang-format * Restyled by gn * fix spaces * fix esp --------- Co-authored-by: Restyled.io <commits@restyled.io>
sarthak shaha (Sarthak-Shaha)
force-pushed
the
automation/update_main
branch
from
14d41b7 to
050e1c2
Compare
sarthak shaha (Sarthak-Shaha)
force-pushed
the
automation/update_main
branch
from
050e1c2 to
47e732b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION