Skip to content

Revert/led#203

Merged
sarthak shaha (Sarthak-Shaha) merged 10 commits into
mainfrom
revert/led
Mar 3, 2026
Merged

Revert/led#203
sarthak shaha (Sarthak-Shaha) merged 10 commits into
mainfrom
revert/led

Conversation

@Sarthak-Shaha
Copy link
Copy Markdown
Contributor

@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) commented Mar 3, 2026 •
edited
Loading

Problem / Feature

Placeholder for reverting/fixing issues from #201

  1. Include MEMLCD configs in board-support/efr32/efr32mg26/BRD4118A/config/sl_memlcd_usart_config.h
  2. Revert any newely introduced led related changes in mgm24
  3. Check in board-support/efr32/mgm24/BRD4316A/config/sl_memlcd_usart_config.h
  4. Revert removal of led files for BRD4318A

Change overview

What's in this PR

Testing

CI for matter _sdk
SiliconLabsSoftware/matter_sdk#871

@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) marked this pull request as ready for review March 3, 2026 16:47
@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) requested a review from a team as a code owner March 3, 2026 16:47
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a50b39ff9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread board-support/efr32/mgm24/BRD4316A/autogen/sl_event_handler.c
@Sarthak-Shaha
Copy link
Copy Markdown
Contributor Author

sarthak shaha (Sarthak-Shaha) commented Mar 3, 2026

codex (Codex (@codex)) review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Mar 3, 2026

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) mentioned this pull request Mar 3, 2026
Merged
@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) merged commit 4a50c51 into main Mar 3, 2026
6 checks passed
@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) deleted the revert/led branch March 3, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@selissia Sergei Lissianoi (selissia) selissia approved these changes

@jmartinez-silabs Junior Martinez (jmartinez-silabs) jmartinez-silabs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sarthak-Shaha @selissia @jmartinez-silabs