Skip to content

Commit fc77d02

Browse files
Copilotkiyarose
andauthored
Address review feedback: icon maps and doc note
Agent-Logs-Url: https://github.com/SillyLittleTech/Flean/sessions/66d7af24-0647-405b-898a-154254a2ab7b Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
1 parent c81eb53 commit fc77d02

3 files changed

Lines changed: 26 additions & 8 deletions

File tree

AGENTS.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,17 @@ Flean is a Safari Web Extension (with native host helpers) that redirects Fandom
5858

5959
## Version numbers
6060

61-
Version numbers live in **two places** and must be kept in sync manually:
61+
Version numbers live in **two places** and must be kept in sync manually. Current values (as of release 2.1.6 / build 3) are shown below — replace them with your next release numbers in **both** projects:
6262

6363
### 1. Extension manifest (`manifest.json`) — `version` field
64-
Both `ios/extention/Resources/manifest.json` and `mos/Flean Extension/Resources/manifest.json` contain:
64+
Both `ios/extention/Resources/manifest.json` and `mos/Flean Extension/Resources/manifest.json` contain the extension version, for example:
6565
```json
6666
"version": "2.1.6"
6767
```
68-
Update this field in **both** files when releasing a new extension version.
68+
Update this value in **both** files for every release.
6969

7070
### 2. Xcode project files (`project.pbxproj`) — `MARKETING_VERSION` and `CURRENT_PROJECT_VERSION`
71-
Both `ios/Flean.xcodeproj/project.pbxproj` and `mos/Flean.xcodeproj/project.pbxproj` contain multiple occurrences of:
71+
Both `ios/Flean.xcodeproj/project.pbxproj` and `mos/Flean.xcodeproj/project.pbxproj` contain multiple occurrences like:
7272
```
7373
MARKETING_VERSION = 2.1.6;
7474
CURRENT_PROJECT_VERSION = 3;
@@ -84,11 +84,17 @@ The icon displayed in the Safari toolbar comes from the `action.default_icon` fi
8484
```json
8585
"action": {
8686
"default_popup": "popup.html",
87-
"default_icon": "images/icon-512.png"
87+
"default_icon": {
88+
"48": "images/icon-48.png",
89+
"96": "images/icon-96.png",
90+
"128": "images/icon-128.png",
91+
"256": "images/icon-256.png",
92+
"512": "images/icon-512.png"
93+
}
8894
}
8995
```
9096

91-
in both `ios/extention/Resources/manifest.json` and `mos/Flean Extension/Resources/manifest.json`. The `images/` directory inside each extension Resources folder contains the icon files (`icon-48.png`, `icon-512.png`, etc.).
97+
in both `ios/extention/Resources/manifest.json` and `mos/Flean Extension/Resources/manifest.json`. The `images/` directory inside each extension Resources folder contains the icon files (`icon-48.png`, `icon-96.png`, `icon-128.png`, `icon-256.png`, `icon-512.png`, etc.).
9298

9399
---
94100

ios/extention/Resources/manifest.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,13 @@
3131

3232
"action": {
3333
"default_popup": "popup.html",
34-
"default_icon": "images/icon-512.png"
34+
"default_icon": {
35+
"48": "images/icon-48.png",
36+
"96": "images/icon-96.png",
37+
"128": "images/icon-128.png",
38+
"256": "images/icon-256.png",
39+
"512": "images/icon-512.png"
40+
}
3541
}
3642

3743
}

mos/Flean Extension/Resources/manifest.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,13 @@
3131

3232
"action": {
3333
"default_popup": "popup.html",
34-
"default_icon": "images/icon-512.png"
34+
"default_icon": {
35+
"48": "images/icon-48.png",
36+
"96": "images/icon-96.png",
37+
"128": "images/icon-128.png",
38+
"256": "images/icon-256.png",
39+
"512": "images/icon-512.png"
40+
}
3541
}
3642

3743
}

0 commit comments

Comments
 (0)