Skip to content

Commit 3db36c6

Browse files
Copilotkiyarose
andauthored
Address PR #253 review comments and adjust preview workflow
Agent-Logs-Url: https://github.com/SillyLittleTech/Portf/sessions/e0e67947-5d7c-4bdd-9aba-1aa674165a7b Co-authored-by: kiyarose <75678535+kiyarose@users.noreply.github.com>
1 parent 2630e5e commit 3db36c6

11 files changed

Lines changed: 21 additions & 13 deletions

File tree

.github/ISSUE_TEMPLATE/content_update.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ body:
2222
attributes:
2323
label: "Affected pages or sections"
2424
description: "List routes, components, or assets that need updates."
25-
placeholder: "Home hero copy, About bio, public/index.html gradient."
25+
placeholder: "Home hero copy, About bio, public/fallback/index.html gradient."
2626
validations:
2727
required: true
2828
- type: textarea

.github/workflows/github-pages-preview.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ permissions:
1010
contents: read
1111
pages: write
1212
id-token: write
13+
pull-requests: write
1314

1415
concurrency:
1516
group: pages-preview-${{ github.event.pull_request.number || github.ref }}

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
- Privacy and legal copy should pull their “Last updated” value from `getBuildUpdatedAt()` so the date reflects the latest build automatically—never hardcode the date.
4343
- Developing skills use a dotted accent pill—follow the existing `isDeveloping` pattern in `SkillsSection` when adding new skills.
4444
- The contact form generates a `mailto:` draft; keep it client-only (no POST handlers) and preserve the copy-to-clipboard CTA.
45-
- The fallback page in `public/index.html` should mirror the warm accent palette; update gradients/buttons there when the brand colors change.
45+
- The fallback page in `public/fallback/index.html` should mirror the warm accent palette; update gradients/buttons there when the brand colors change.
4646

4747
## Testing Guidelines
4848

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Below are suggestions and quick checks to help you convert this repo into your o
1919
- Important: this template includes a BSD-3-Clause `LICENSE` that must be preserved as-is in the source
2020
when redistributing or publishing derived works (see `LICENSE.example` for how to add your own copyright
2121
attribution without removing the original line).
22-
- `public/index.html` and `src/data/*` — replace demo content with your personal content.
22+
- `public/fallback/index.html` and `src/data/*` — replace demo content with your personal content.
2323

2424
- If you plan to accept outside contributions on your fork, add a `CODE_OF_CONDUCT.md`, a `PULL_REQUEST_TEMPLATE.md`, and/or an `ISSUE_TEMPLATE/` directory so contributors have clear expectations.
2525

LICENSE.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Choose the license that aligns with how you want others to use and contribute to
3939

4040
- Fork the repo.
4141
- Update `LICENSE` (change copyright line and year).
42-
- Update `README.md` and `public/index.html` with your site name and contact info.
42+
- Update `README.md` and `public/fallback/index.html` with your site name and contact info.
4343
- Replace `src/data/*` content with your portfolio data.
4444
- Update `package.json` `name` and `license` fields.
4545

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
"react-dom": "^19.2.0",
3434
"tailwind-merge": "^3.3.1",
3535
"tailwindcss": "^4.1.8",
36-
"wrangler": "^4.16.0",
37-
"zod": "^4.1.12"
36+
"wrangler": "^4.16.0"
3837
},
3938
"devDependencies": {
4039
"@astrojs/check": "^0.9.9",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<title>Something Went Wrong · Your Name</title>
1111
<meta
1212
name="description"
13-
content="Fallback page for the template portfolio when the main application cannot load. Replace this content in public/index.html if desired."
13+
content="Fallback page for the template portfolio when the main application cannot load. Replace this content in public/fallback/index.html if desired."
1414
/>
1515
<style>
1616
@font-face {

src/hooks/useRemoteData.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ const DATA_BASE_URL = resolveRemoteDataBaseUrl(
1111
import.meta.env.VITE_REMOTE_DATA_URL as string | undefined,
1212
);
1313
const REMOTE_DATA_ENABLED = DATA_BASE_URL !== null;
14-
const REMOTE_DATA_PATH = "/__remote-data";
14+
const REMOTE_DATA_PATH = `${import.meta.env.BASE_URL}__remote-data`.replace(
15+
/\/{2,}/g,
16+
"/",
17+
);
1518

1619
// LocalStorage namespace for cached remote data. Rename if you fork the template
1720
// to avoid collisions with other apps in the browser.

src/layouts/BaseLayout.astro

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ const {
1010
title = "Portfolio Starter",
1111
description = "A modular portfolio starter built with Astro and React.",
1212
} = Astro.props as Props;
13+
const faviconHref = `${import.meta.env.BASE_URL}favicon.svg`.replace(
14+
/\/{2,}/g,
15+
"/",
16+
);
1317
---
1418

1519
<!doctype html>
@@ -18,6 +22,7 @@ const {
1822
<meta charset="UTF-8" />
1923
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
2024
<meta name="description" content={description} />
25+
<link rel="icon" type="image/svg+xml" href={faviconHref} />
2126
<script is:inline>
2227
(() => {
2328
try {

0 commit comments

Comments
 (0)