Skip to content

✨ Add multiday view option to web#542

Open
lavigarg-simform wants to merge 1 commit into
masterfrom
feat/add-multiday-to-web
Open

✨ Add multiday view option to web#542
lavigarg-simform wants to merge 1 commit into
masterfrom
feat/add-multiday-to-web

Conversation

@lavigarg-simform

@lavigarg-simform lavigarg-simform commented May 27, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds MultiDayView as a selectable calendar view option in the example app on web and introduces new customization parameters to MultiDayView.

What changed

Example app

  • Added multiday to the CalendarView enum so users can switch to MultiDayView from the view selector on web.
  • Added the corresponding label via translate.multidayView in the CalendarConfig widget.
  • Wired MultiDayViewWidget into the CalendarViews routing so the example app renders it when multiday is selected.
  • Removed the hard-coded maxWidth: 30 constraint from SideEventArranger() in MultiDayViewWidget.

MultiDayView / InternalMultiDayViewPage

  • Added weekTitleBackgroundColor (Color?) to MultiDayView and InternalMultiDayViewPage to allow customizing the week title strip background. Falls back to themeColor.multiDayTileColor when not provided.
  • Added backgroundColor propagation from MultiDayView down to InternalMultiDayViewPage, where it is applied directly on the page container (replaces the now-removed DecoratedBox wrapper).
  • Removed the redundant DecoratedBox that previously wrapped the PageView.builder.
  • Cleaned up dead commented-out code (updateRange(), showWeekEnds removal block).

CalendarEventData

  • Fixed occursOnDate to use withoutTime consistently on both sides of comparisons, preventing false negatives caused by time-component mismatches.
  • Minor formatting: moved @immutable annotation directly above the class declaration.

Constructor style

  • Reformatted InternalMultiDayViewPage constructor to use the trailing-comma / one-parameter-per-line Dart style.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

No related issues.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds MultiDayView support to the example app’s web view selector and extends MultiDayView customization for week-title and page backgrounds, while also fixing date-only matching in CalendarEventData.

Changes:

  • Added CalendarView.multiday routing/label support in the example web selector.
  • Added weekTitleBackgroundColor and propagated page backgroundColor into InternalMultiDayViewPage.
  • Updated occursOnDate to compare dates without time components and expanded MultiDayView documentation/changelog notes.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lib/src/multi_day_view/multi_day_view.dart Adds the new week-title background parameter and passes background colors into internal pages.
lib/src/multi_day_view/_internal_multi_day_view_page.dart Applies page and week-title background colors inside each MultiDayView page.
lib/src/calendar_event_data.dart Normalizes date comparisons in occursOnDate.
example/lib/widgets/multi_day_view_widget.dart Removes the fixed side-event arranger max width.
example/lib/widgets/calendar_views.dart Routes the new enum option to MultiDayViewWidget.
example/lib/widgets/calendar_configs.dart Adds the localized multiday label to the view selector.
example/lib/enumerations.dart Adds the multiday calendar view option.
doc/documentation.md Documents new MultiDayView customization options.
CHANGELOG.md Adds an unreleased entry for the new MultiDayView option.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread example/lib/enumerations.dart
Comment thread CHANGELOG.md Outdated
@lavigarg-simform lavigarg-simform force-pushed the feat/add-multiday-to-web branch from 4a24fa2 to 7181614 Compare May 27, 2026 15:48
@lavigarg-simform lavigarg-simform marked this pull request as ready for review May 27, 2026 15:48

@kavantrivedi kavantrivedi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey
Lavi, can you please check background in web. as it is different from mobile tablet view

Image Image

@kavantrivedi

Copy link
Copy Markdown
Contributor

Hey Lavi, can you please check background in web. as it is different from mobile tablet view

Image Image

Working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants