🐛 Fix scroll behavior by replacing ScrollController with ZoomScrollController#543
Open
kavantrivedi wants to merge 1 commit into
Open
🐛 Fix scroll behavior by replacing ScrollController with ZoomScrollController#543kavantrivedi wants to merge 1 commit into
kavantrivedi wants to merge 1 commit into
Conversation
kavantrivedi
force-pushed
the
fix/scroll_exception_issue
branch
2 times, most recently
from
eb06e59 to
ea99aac
Compare
kavantrivedi
requested review from
PRBaraiya and
Copilot
and removed request for
PRBaraiya
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses scroll-controller exceptions by moving Day, Week, and MultiDay views toward per-page ZoomScrollController instances and tracking active/page-specific scroll offsets.
Changes:
- Adds per-page scroll offset caching and active scroll controller tracking in DayView, WeekView, and MultiDayView.
- Updates internal page widgets to own their local
ZoomScrollControllerand report page index/controller details to parents. - Updates the example and changelog to reflect the scroll behavior fix.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
lib/src/day_view/day_view.dart |
Tracks per-page offsets and active controller for DayView scrolling. |
lib/src/day_view/_internal_day_view_page.dart |
Switches DayView pages to always use local ZoomScrollController. |
lib/src/week_view/week_view.dart |
Tracks per-page offsets and active controller for WeekView scrolling. |
lib/src/week_view/_internal_week_view_page.dart |
Switches WeekView pages to always use local ZoomScrollController. |
lib/src/multi_day_view/multi_day_view.dart |
Tracks per-page offsets and active controller for MultiDayView scrolling. |
lib/src/multi_day_view/_internal_multi_day_view_page.dart |
Switches MultiDayView pages to always use local ZoomScrollController. |
example/lib/widgets/day_view_widget.dart |
Enables keepScrollOffset in the DayView example. |
CHANGELOG.md |
Adds an entry for the scroll exception fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kavantrivedi
force-pushed
the
fix/scroll_exception_issue
branch
from
ea99aac to
1b1ec03
Compare
kavantrivedi
force-pushed
the
fix/scroll_exception_issue
branch
from
1b1ec03 to
f525134
Compare
| - Updated documentation for `DayView`, `WeekView`, `MonthView` and `MultiDayView` to add more details about the parameters and their usage. [#448](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/pull/448) | ||
| - Fixed `onlyShowToday` parameter in `WeekView` to update `liveTimeIndicator` properly. [#518](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/issues/518) | ||
| - Added `ZoomScrollController` to `DayView`, `WeekView` and `MultiDayView` for programmatic control of zoom level and scroll position. [#522](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/issues/522) | ||
| - Fixed issue with scroll exception when using `ZoomScrollController` in `DayView` and `WeekView`. [#543](https://github.com/SimformSolutionsPvtLtd/flutter_calendar_view/pull/543) |
Contributor
There was a problem hiding this comment.
Please remove this entry as this exception is related to the change above
kavantrivedi
force-pushed
the
fix/scroll_exception_issue
branch
from
f525134 to
2257fe4
Compare
Contributor
|
@kavantrivedi Please add a small section in documentation as well for ZoomScrollController |
kavantrivedi
force-pushed
the
fix/scroll_exception_issue
branch
from
2257fe4 to
147f259
Compare
…ntroller and updating scroll listener parameters across day, multi-day, and week views
kavantrivedi
force-pushed
the
fix/scroll_exception_issue
branch
from
147f259 to
78d29f0
Compare
lavigarg-simform
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix scroll behavior by replacing ScrollController with ZoomScrollController and updating scroll listener parameters across day, multi-day, and week views
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues