fix: 🐛 fix semantics issue when using go router (#622)#625
Merged
vatsaltanna-simformsolutions merged 2 commits intoJun 17, 2026
Conversation
Sahil-Simform
force-pushed
the
fix/issue_622_semantics_issue
branch
from
22e3ade to
55f6395
Compare
Copilot started reviewing on behalf of
vatsaltanna-simformsolutions
April 24, 2026 11:38
View session
There was a problem hiding this comment.
Pull request overview
Fixes a semantics debugger visibility issue where Showcase title/description nodes don’t appear when using go_router with showSemanticsDebugger = true.
Changes:
- Wrap the overlay tree with a
Semanticswidget inOverlayManagerto influence semantics propagation/visibility. - Add a changelog entry referencing the fix for #622.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/src/utils/overlay_manager.dart | Adds a top-level Semantics wrapper around the overlay subtree. |
| CHANGELOG.md | Documents the fix for issue #622 in the unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vasu-nageshri-simform
force-pushed
the
fix/issue_622_semantics_issue
branch
from
55f6395 to
37ed831
Compare
vasu-nageshri-simform
force-pushed
the
fix/issue_622_semantics_issue
branch
from
37ed831 to
13a88fa
Compare
vatsaltanna-simformsolutions
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While using
go_routerwithshowSemanticsDebugger = true, the title and description are not visible in the semantics debug view, even though accessibility works as expected. This PR resolves the issue.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #622
Before:
After: