Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Fixed [#633](https://github.com/SimformSolutionsPvtLtd/showcaseview/issues/633) - Added `ShowcaseView.isTargetRendered` to detect whether a showcase target is currently rendered, replacing the 4.x.x `key.currentContext` / `key.currentWidget` check. Fixed by @[vatsaltanna-simformsolutions](https://github.com/vatsaltanna-simformsolutions)
- Fixed [#645](https://github.com/SimformSolutionsPvtLtd/showcaseview/issues/645) - Prevent re-entrant calls to _onComplete during rapid barrier taps. Fixed by @[apizon](https://github.com/apizon)
- Fixed [#639](https://github.com/SimformSolutionsPvtLtd/showcaseview/issues/639) - Add null-safety guards for async sequence transitions. Fixed by @[vasu-nageshri](https://github.com/vasu-nageshri)
- Fixed [#622](https://github.com/SimformSolutionsPvtLtd/showcaseview/issues/622) - Resolve Semantics issue when using `go_router` and `showSemanticsDebugger` flag. Fixed by @[Sahil-Simform](https://github.com/Sahil-Simform)

## [5.0.2]

Expand Down
15 changes: 14 additions & 1 deletion lib/src/utils/overlay_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ class OverlayManager {

// Wrap with other inherited widgets to maintain showcase's context's
// inherited values.
return Directionality(
final overlayContent = Directionality(
textDirection: inheritedData.textDirection,
child: MediaQuery(
data: inheritedData.mediaQuery,
Expand All @@ -227,6 +227,19 @@ class OverlayManager {
),
),
);

// Only add showcase-specific semantics when explicitly enabled via
// `showcaseView.semanticEnable`. When disabled, preserve descendant
// widgets' default semantics instead of stripping them from the overlay
// subtree.
if (showcaseView.semanticEnable) {
return Semantics(
liveRegion: true,
child: overlayContent,
);
}

return overlayContent;
}

/// Extracts and returns linked showcase data from controllers.
Expand Down
Loading