fix: 🐛 Prevent re-entrant calls to _onComplete during rapid barri…#646
Closed
apizon wants to merge 3 commits into
Closed
fix: 🐛 Prevent re-entrant calls to _onComplete during rapid barri…#646apizon wants to merge 3 commits into
apizon wants to merge 3 commits into
Conversation
…aps (SimformSolutionsPvtLtd#645) Add _isCompleting boolean guard to prevent concurrent execution of _onComplete() when rapid barrier taps occur during step transition animations. This prevents null-check crashes from calling reverse() on already-disposed AnimationControllers. Fixes crash when user rapidly taps the barrier during showcase step transitions.
vatsaltanna-simformsolutions
approved these changes
Jun 8, 2026
Contributor
|
Hello @apizon, I was able to reproduce the same issue using the code you provided. Could you please take a look and confirm? For reference, I've attached a video demonstrating the problem. Thank you! Screen.Recording.2026-06-11.at.11.07.29.AM.mov |
Contributor
Author
|
Hi @vasu-nageshri, It looks like the PR is not fixing the issue indeed, at least not when using programmatic auto-spam... (also tried it on my end with same result as you) Anyway, I'm affraid I'm out of ideas for this one, I've reverted to 4.0 in the meantime since it works with no issue on my app. |
vatsaltanna-simformsolutions
approved these changes
Jun 16, 2026
Contributor
|
Close, as it has been resolved in #654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add _isCompleting boolean guard to prevent concurrent execution of _onComplete()
when rapid barrier taps occur during step transition animations. This prevents
null-check crashes from calling reverse() on already-disposed AnimationControllers.
Fixes crash when user rapidly taps the barrier during showcase step transitions (#645).
Tested if on my app and can confirm I now longer see any assertion failures or unhandled exceptions.
Checklist
fix:,feat:,docs:etc).///.Breaking Change?
Related Issues
Fixes #645