fix: 🐛 Prevent re-entrant calls to _onComplete during rapid barrier taps (#645)#654
Merged
Merged
Conversation
vasu-nageshri-simform
force-pushed
the
fix/rapid-taps
branch
from
5425627 to
a5262bf
Compare
…aps (#645) Add _isCompleting boolean guard to prevent concurrent execution of _onComplete() when rapid barrier taps occur during step transition animations. This prevents null-check crashes from calling reverse() on already-disposed AnimationControllers. Fixes crash when user rapidly taps the barrier during showcase step transitions.
vasu-nageshri-simform
force-pushed
the
fix/rapid-taps
branch
from
a5262bf to
0bbea9b
Compare
vatsaltanna-simformsolutions
approved these changes
Jun 16, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add _isCompleting boolean guard to prevent concurrent execution of _onComplete()
when rapid barrier taps occur during step transition animations. This prevents
null-check crashes from calling reverse() on already-disposed AnimationControllers.
Fixes crash when user rapidly taps the barrier during showcase step transitions.
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Fixes #645